Closed Bug 1408929 Opened 3 years ago Closed 3 years ago

Enable browser_webconsole_completion.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Blocks: 1400847
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8929403 [details]
Bug 1408929 - Rename and enable browser_webconsole_completion.js in the new console frontend; .

https://reviewboard.mozilla.org/r/200732/#review205936

Looks good, thanks! (just one random question)

::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:335
(Diff revision 1)
> + *                  Will default to COMPLETE_HINT_ONLY.
> + * @returns {Promise} resolves when the jsterm is completed.
> + */
> +function jstermComplete(jsterm, completionType) {
>    const updated = jsterm.once("autocomplete-updated");
> -  jsterm.complete(jsterm.COMPLETE_HINT_ONLY);
> +  completionType = completionType === undefined || completionType === null

why not use a default argument value here instead?
Attachment #8929403 - Flags: review?(jdescottes) → review+
Oh, I did not think it would work in argument to use properties from another argument, great !
I'll update the patch
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02a2365fd62b
Rename and enable browser_webconsole_completion.js in the new console frontend; r=jdescottes.
Priority: P3 → P1
Whiteboard: [newconsole-mvp]
https://hg.mozilla.org/mozilla-central/rev/02a2365fd62b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.