1408929 - Enable browser_webconsole_completion.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1408929 - Rename and enable browser_webconsole_completion.js in the new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/200732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200732/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8929403 [details]
Bug 1408929 - Rename and enable browser_webconsole_completion.js in the new console frontend; .

https://reviewboard.mozilla.org/r/200732/#review205936

Looks good, thanks! (just one random question)

::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:335
(Diff revision 1)
> + *                  Will default to COMPLETE_HINT_ONLY.
> + * @returns {Promise} resolves when the jsterm is completed.
> + */
> +function jstermComplete(jsterm, completionType) {
>    const updated = jsterm.once("autocomplete-updated");
> -  jsterm.complete(jsterm.COMPLETE_HINT_ONLY);
> +  completionType = completionType === undefined || completionType === null

why not use a default argument value here instead?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Oh, I did not think it would work in argument to use properties from another argument, great !
I'll update the patch

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8929403 [details]
Bug 1408929 - Rename and enable browser_webconsole_completion.js in the new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200732/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02a2365fd62b
Rename and enable browser_webconsole_completion.js in the new console frontend; r=jdescottes.

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/02a2365fd62b