Closed Bug 1408934 Opened 2 years ago Closed 2 years ago

Enable browser_webconsole_deactivateHUDForContext_unfocused_window.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2c1a70d005283d702191b604b9a01794bf5e131

I renamed the test because the method deactivateHUDForContext is no longer part of the codebase, so a bit irrelevant. Also the test is supposed to check what happens when we close an unfocused window, but closing the toolbox actually focuses the window, so hard to tell if this is still asserting what it was supposed to assert.

The behavior is the same as the one of the old console FWIW.
Comment on attachment 8933728 [details]
Bug 1408934 - enable browser_webconsole_deactivateHUDForContext_unfocused_window.js;

https://reviewboard.mozilla.org/r/204670/#review210576

Very nice!

Just couple of nits iniline

R+

Thanks Julian,
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini:237
(Diff revision 1)
>  tags = mcb
>  [browser_webconsole_cached_messages.js]
>  [browser_webconsole_cd_iframe.js]
>  [browser_webconsole_certificate_messages.js]
>  [browser_webconsole_click_function_to_source.js]
> -skip-if = true #	Bug 1406038
> +skip-if = true #  Bug 1406038

nit: two spaces (one is enough)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini:243
(Diff revision 1)
>  [browser_webconsole_clickable_urls.js]
> +[browser_webconsole_close_unfocused_window.js]
>  [browser_webconsole_closing_after_completion.js]
>  [browser_webconsole_close_sidebar.js]
>  [browser_webconsole_closure_inspection.js]
> -skip-if = true #	Bug 1405250
> +skip-if = true #  Bug 1405250

nit: two spaces (one is enough)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini:262
(Diff revision 1)
>  [browser_webconsole_context_menu_copy_object.js]
>  subsuite = clipboard
>  [browser_webconsole_context_menu_open_url.js]
>  [browser_webconsole_context_menu_store_as_global.js]
>  [browser_webconsole_copy_link_location.js]
> -skip-if = true #	Bug 1401944
> +skip-if = true #  Bug 1401944

nit: two spaces (one is enough)
Attachment #8933728 - Flags: review?(odvarko) → review+
Comment on attachment 8933728 [details]
Bug 1408934 - enable browser_webconsole_deactivateHUDForContext_unfocused_window.js;

https://reviewboard.mozilla.org/r/204670/#review210576

Thanks for the review Honza. Addressed the comments (I have no idea how those whitespace changes got into my commit however!)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c888dbc7f5fd
enable browser_webconsole_deactivateHUDForContext_unfocused_window.js;r=Honza
https://hg.mozilla.org/mozilla-central/rev/c888dbc7f5fd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.