1408935 - Enable browser_webconsole_errors_after_page_reload.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f916992d9a3fb883ff038b60086b17f55c91acfe

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

Review commit: https://reviewboard.mozilla.org/r/204666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204666/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8933720 [details]
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

https://reviewboard.mozilla.org/r/204666/#review210504

A couple of nots on the working, but the code looks good, r+ !

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js:18
(Diff revision 1)
> -    });
> -
> -    yield hud.target.once("navigate");
> -    info("target navigated");
>  
> -    let button = content.document.querySelector("button");
> +  info("Reload the content window to produce a network log");

I don't think this is the goal here (and because the request filter is off by default it won't show up anyway)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js:36
(Diff revision 1)
>  
> -    EventUtils.sendMouseEvent({type: "click"}, button, content);
> +  let onMessage = waitForMessage(hud, "fooBazBaz is not defined");
> +  BrowserTestUtils.synthesizeMouseAtCenter("button", {}, gBrowser.selectedBrowser);
> +  await onMessage;
>  
> -    yield waitForMessages({
> +  ok(true, "Received the expected message");

nit: s/expected message/expected error message

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8933720 [details]
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204666/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8933720 [details]
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

https://reviewboard.mozilla.org/r/204666/#review210504

Thanks for the review! Addressed comments, landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c0dd19237a7
enable browser_webconsole_errors_after_page_reload.js;r=nchevobbe

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4c0dd19237a7