Closed Bug 1408935 Opened 3 years ago Closed 2 years ago

Enable browser_webconsole_errors_after_page_reload.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8933720 [details]
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

https://reviewboard.mozilla.org/r/204666/#review210504

A couple of nots on the working, but the code looks good, r+ !

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js:18
(Diff revision 1)
> -    });
> -
> -    yield hud.target.once("navigate");
> -    info("target navigated");
>  
> -    let button = content.document.querySelector("button");
> +  info("Reload the content window to produce a network log");

I don't think this is the goal here (and because the request filter is off by default it won't show up anyway)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js:36
(Diff revision 1)
>  
> -    EventUtils.sendMouseEvent({type: "click"}, button, content);
> +  let onMessage = waitForMessage(hud, "fooBazBaz is not defined");
> +  BrowserTestUtils.synthesizeMouseAtCenter("button", {}, gBrowser.selectedBrowser);
> +  await onMessage;
>  
> -    yield waitForMessages({
> +  ok(true, "Received the expected message");

nit: s/expected message/expected error message
Attachment #8933720 - Flags: review?(nchevobbe) → review+
Comment on attachment 8933720 [details]
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;

https://reviewboard.mozilla.org/r/204666/#review210504

Thanks for the review! Addressed comments, landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c0dd19237a7
enable browser_webconsole_errors_after_page_reload.js;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/4c0dd19237a7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.