Closed Bug 1408938 Opened 2 years ago Closed 2 years ago

Enable browser_webconsole_history.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: pbro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment on attachment 8931720 [details]
Bug 1408938 - Enable and rename browser_webconsole_history.js;

https://reviewboard.mozilla.org/r/202860/#review208192

The changes look good, thanks patrick !
A couple of thing : 
- I think you forgot to remove the "skip-if=true" in browser.ini
- Could you rename this test into browser_jsterm_history.js ? We plan to refactor jsterm next year, and having all the specific tests for it prefixed this way will make things easier.

Thanks !

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_history.js:15
(Diff revision 1)
>  const HISTORY_BACK = -1;
>  const HISTORY_FORWARD = 1;
> +const COMMANDS = ["document", "window", "window.location"];
>  
> -add_task(function* () {
> -  yield loadTab(TEST_URI);
> +add_task(async function () {
> +  const { jsterm } = await openNewTabAndConsole("data:text/html;charset=UTF-8,test");

would you mind keeping the TEST_URI const at the top and put the data url in it, so we keep consistency between all the tests.
Attachment #8931720 - Flags: review?(nchevobbe) → review+
Priority: P2 → P1
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/067659e3751f
Enable and rename browser_webconsole_history.js; r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/067659e3751f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.