1408938 - Enable browser_webconsole_history.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1408938 - Enable and rename browser_webconsole_history.js;

Review commit: https://reviewboard.mozilla.org/r/202860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202860/

Comment 2

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58520f50f6b6ad7d8452f7a20f1b42a1b315495d

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8931720 [details]
Bug 1408938 - Enable and rename browser_webconsole_history.js;

https://reviewboard.mozilla.org/r/202860/#review208192

The changes look good, thanks patrick !
A couple of thing : 
- I think you forgot to remove the "skip-if=true" in browser.ini
- Could you rename this test into browser_jsterm_history.js ? We plan to refactor jsterm next year, and having all the specific tests for it prefixed this way will make things easier.

Thanks !

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_history.js:15
(Diff revision 1)
>  const HISTORY_BACK = -1;
>  const HISTORY_FORWARD = 1;
> +const COMMANDS = ["document", "window", "window.location"];
>  
> -add_task(function* () {
> -  yield loadTab(TEST_URI);
> +add_task(async function () {
> +  const { jsterm } = await openNewTabAndConsole("data:text/html;charset=UTF-8,test");

would you mind keeping the TEST_URI const at the top and put the data url in it, so we keep consistency between all the tests.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8931720 [details]
Bug 1408938 - Enable and rename browser_webconsole_history.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202860/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/067659e3751f
Enable and rename browser_webconsole_history.js; r=nchevobbe

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/067659e3751f