Closed Bug 1408941 Opened 2 years ago Closed 2 years ago

Enable browser_webconsole_multiline_input.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Priority: P2 → P1
Comment on attachment 8932622 [details]
Bug 1408941 - Enable browser_webconsole_multiline_input.js;

https://reviewboard.mozilla.org/r/203670/#review209280

Looks good, thanks Julian !
Only one comment about renaming the test, but goog to land :)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini:348
(Diff revision 1)
>  skip-if = true #	Bug 1404384
>  # old console skip-if = e10s # Bug 1042253 - webconsole tests disabled with e10s
>  [browser_webconsole_mixedcontent.js]
>  tags = mcb
>  skip-if = true #	Bug 1404886
>  [browser_webconsole_multiline_input.js]

Could we rename the test to browser_jsterm_multiline.js ? We plan to do a refactor of the jsterm next year, and it would be nice if we could have all the related test prefixed this way to make our life easier :)
Attachment #8932622 - Flags: review?(nchevobbe) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7a40b75ddf0
Enable browser_webconsole_multiline_input.js;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/d7a40b75ddf0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.