1408941 - Enable browser_webconsole_multiline_input.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1408941 - Enable browser_webconsole_multiline_input.js;

Review commit: https://reviewboard.mozilla.org/r/203670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203670/

Comment 2

[Julian Descottes [:jdescottes]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01d17ef40dcd3e3a8d5a9f8c9d5229d76545142c

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8932622 [details]
Bug 1408941 - Enable browser_webconsole_multiline_input.js;

https://reviewboard.mozilla.org/r/203670/#review209280

Looks good, thanks Julian !
Only one comment about renaming the test, but goog to land :)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini:348
(Diff revision 1)
>  skip-if = true #	Bug 1404384
>  # old console skip-if = e10s # Bug 1042253 - webconsole tests disabled with e10s
>  [browser_webconsole_mixedcontent.js]
>  tags = mcb
>  skip-if = true #	Bug 1404886
>  [browser_webconsole_multiline_input.js]

Could we rename the test to browser_jsterm_multiline.js ? We plan to do a refactor of the jsterm next year, and it would be nice if we could have all the related test prefixed this way to make our life easier :)

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8932622 [details]
Bug 1408941 - Enable browser_webconsole_multiline_input.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203670/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a40b75ddf0
Enable browser_webconsole_multiline_input.js;r=nchevobbe

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d7a40b75ddf0