1408944 - Enable browser_webconsole_network_requests_from_chrome.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Patrick Brosset <:pbro>]

Taking this one as my first new console test enabling bug. It seems to be easy enough. Although it's quite cryptic to me what is this listener service and what referencing HUDService even does.
But anyway, I think I can make progress and I'll ask for a review.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1408944 - Rewrite and enable browser_webconsole_network_requests_from_chrome.js;

Review commit: https://reviewboard.mozilla.org/r/201996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201996/

Comment 3

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=814dbe00924a9cfc1766013762fc120baee64610

Comment 4

[Patrick Brosset <:pbro>]

I tested it locally with mach test --verify --headless. Worked great. But I suspect it already passed (since it doesn't even involve opening the console).

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8930884 [details]
Bug 1408944 - Rewrite and enable browser_webconsole_network_requests_from_chrome.js;

https://reviewboard.mozilla.org/r/201996/#review207430

Thanks Patrick ! Only a small nit, but this is good to land.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_network_requests_from_chrome.js:13
(Diff revision 1)
>  
>  "use strict";
>  
>  const TEST_URI = "http://example.com/";
>  
> -var good = true;
> +add_task(function* () {

can we switch to async/await ?

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8930884 [details]
Bug 1408944 - Rewrite and enable browser_webconsole_network_requests_from_chrome.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201996/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01298c757565
Rewrite and enable browser_webconsole_network_requests_from_chrome.js; r=nchevobbe

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/01298c757565