Closed Bug 1408950 Opened 3 years ago Closed 3 years ago

Enable browser_webconsole_websocket.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: mpark)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → mpark
Comment on attachment 8930600 [details]
Bug 1408950 - Enable browser_webconsole_websocket.js in the new console frontend.

https://reviewboard.mozilla.org/r/201712/#review207320

Neat ! Ready to land once we figure out the test-websocket.html file issue

::: devtools/client/webconsole/new-console-output/test/mochitest/test-websocket.html:1
(Diff revision 1)
> +<!DOCTYPE html>
> +<html lang="en">
> +  <head>
> +    <meta charset="utf-8">
> +    <title>Web Console test for Web Socket errors</title>
> +    <!-- Any copyright is dedicated to the Public Domain.
> +         http://creativecommons.org/publicdomain/zero/1.0/ -->
> +  </head>
> +  <body>
> +    <p>Web Console test for Web Socket errors.</p>
> +    <iframe srcdoc="hello world!"></iframe>
> +    <script type="text/javascript" src="test-websocket.js"></script>
> +  </body>

it looks like this file has been created new instead of moved from the old one. 
Could you check please ?
Attachment #8930600 - Flags: review?(nchevobbe) → review+
TRY is green
Status: NEW → ASSIGNED
Priority: P2 → P1
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s acd6ddba8ff1 -d 99f4d3702ed6: rebasing 440649:acd6ddba8ff1 "Bug 1408950 - Enable browser_webconsole_websocket.js in the new console frontend. r=nchevobbe" (tip)
merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
warning: conflicts while merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment on attachment 8939906 [details]
Bug 1408950 - Enable browser_webconsole_websocket.js in the new console frontend.

https://reviewboard.mozilla.org/r/210206/#review215904
Attachment #8939906 - Flags: review?(nchevobbe) → review+
Comment on attachment 8930600 [details]
Bug 1408950 - Enable browser_webconsole_websocket.js in the new console frontend.

Marking as obsolete since it needed to be rebased and Mike is not around anymore
Attachment #8930600 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38b6a5527c29
Enable browser_webconsole_websocket.js in the new console frontend. r=nchevobbe
Blocks: 1428162
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/9b7b27dd0cef
Enable browser_webconsole_websocket.js in the new console frontend. r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/9b7b27dd0cef
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.