1408977 - Support running wpt with chaos mode

Status: RESOLVED FIXED

Description

[James Graham [:jgraham]]

Allow running wpt tests under chaos mode using a --chaos flag.

Comment 1

[James Graham [:jgraham]]

Created attachment 8918821 [details]
Bug 1408977 - Allow running wpt test with chos mode using --chaos[=flag],

Review commit: https://reviewboard.mozilla.org/r/189682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189682/

Comment 2

[Geoff Brown [:gbrown] (away Feb 18, 19)]

Comment on attachment 8918821 [details]
Bug 1408977 - Allow running wpt test with chos mode using --chaos[=flag],

https://reviewboard.mozilla.org/r/189682/#review195120

This looks fine - thanks!

::: testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py:203
(Diff revision 1)
>                               help="Disable reftest runner implemented inside Marionette")
>      gecko_group.add_argument("--reftest-screenshot", dest="reftest_screenshot", action="store",
>                               choices=["always", "fail", "unexpected"], default="unexpected",
>                               help="With --reftest-internal, when to take a screenshot")
> +    gecko_group.add_argument("--chaos", dest="chaos_mode_flags", action="store",
> +                             nargs="?", const=3, type=int,

Did you make the default 3 because that's what --verify uses? That's reasonable, but be aware that's (hopefully) a temporary condition. I hope to enable all chaos mode features for --verify (bug 1390884), eventually.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8918821 [details]
Bug 1408977 - Allow running wpt test with chos mode using --chaos[=flag],

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189682/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/917b66c1e16d
Allow running wpt test with chos mode using --chaos[=flag], r=gbrown

Comment 5

[Sebastian Hengst [PTO+professional development; back to normal activity 2019-02-25][:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/917b66c1e16d