1409000 - The password update dialog keeps popping up in the area for registered users in Gatwick Express website

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Soledad Penades [:sole] [:spenades]]

Attachment: Short GIF demoing the issue

I don't know what is it they are doing, but it is deeply annoying to have the dialog pop up each time I change to a different page.

Steps to reproduce:

- log into Gatwick Express website
- pop up starts to show each time the user clicks on a different option from the left hand side (Account Details, addresses, payment details...)

I enabled the password manager debugger following the instructions here: https://wiki.mozilla.org/Firefox:Password_Manager_Debugging

This is the output I get on the Browser console once I navigate between the options in the user area (I have edited my email address out):

13:58:53.052 onLocationChange handled: "https://ticket.gatwickexpress.com/account/details" <unavailable>  LoginManagerContent.jsm:87
13:58:53.053 _onNavigation: state: <unavailable> loginFormRootElements size: 1 document: <unavailable>  LoginManagerContent.jsm:886
13:58:53.055 _onFormSubmit <unavailable>  LoginManagerContent.jsm:912
13:58:53.056 _filterRecipesForForm <unavailable>  LoginRecipes.jsm:261
13:58:53.056 getFieldOverrides: filtered recipes: <unavailable>  LoginRecipes.jsm:286
13:58:53.057 Username field  <unavailable> has name/value:  / [e-mail]  LoginManagerContent.jsm:802
13:58:53.057 Password field <unavailable> has name:    LoginManagerContent.jsm:810
13:58:53.060 nsLoginManager:Checking if logins to "https://ticket.gatwickexpress.com" can be saved.  nsLoginManager.js:439
13:58:53.062 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:53.068 Login storage:_searchLogins: returning 1 logins for Object { hostname: "https://ticket.gatwickexpress.com", formSubmitURL: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:53.072 LoginManagerParent:Found an existing login matching this form submission  LoginManagerParent.jsm:400
13:58:53.074 LoginManagerParent:...passwords differ, prompting to change.  LoginManagerParent.jsm:404
13:58:53.074 LoginManagerPrompter:===== initialized =====  nsLoginManagerPrompter.js:751
13:58:53.075 LoginManagerPrompter:promptToChangePassword  nsLoginManagerPrompter.js:1240
13:58:53.292 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:53.303 Login storage:_searchLogins: returning 1 logins for Object { httpRealm: null, formSubmitURL: "https://ticket.gatwickexpress.com", hostname: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:53.268 Created non-form FormLike for rootElement: <unavailable>  LoginManagerContent.jsm:1627
13:58:53.268 adding <unavailable> to loginFormRootElements for <unavailable>  LoginManagerContent.jsm:1631
13:58:53.269 onDOMInputPasswordAdded: <unavailable> <unavailable>  LoginManagerContent.jsm:399
13:58:53.269 Creating a DeferredTask to call _fetchLoginsFromParentAndFillForm soon  LoginManagerContent.jsm:403
13:58:53.269 Arming the DeferredTask we just created since document.readyState == 'complete'  LoginManagerContent.jsm:424
13:58:53.270 Created non-form FormLike for rootElement: <unavailable>  LoginManagerContent.jsm:1627
13:58:53.270 adding <unavailable> to loginFormRootElements for <unavailable>  LoginManagerContent.jsm:1631
13:58:53.272 Running deferred processing of onDOMInputPasswordAdded <unavailable>  LoginManagerContent.jsm:410
13:58:53.272 _detectInsecureFormLikes "https://ticket.gatwickexpress.com/account/details"  LoginManagerContent.jsm:489
13:58:53.385 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:53.392 Login storage:_searchLogins: returning 1 logins for Object { hostname: "https://ticket.gatwickexpress.com", formSubmitURL: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:53.395 LoginManagerParent:sendLoginDataToChild: 1 deduped logins  LoginManagerParent.jsm:220
13:58:53.396 cacheRecipes: for: "https://ticket.gatwickexpress.com"  LoginRecipes.jsm:207
13:58:53.397 _fillForm <unavailable>  LoginManagerContent.jsm:1019
13:58:53.397 _filterRecipesForForm <unavailable>  LoginRecipes.jsm:261
13:58:53.398 getFieldOverrides: filtered recipes: <unavailable>  LoginRecipes.jsm:286
13:58:53.398 Username field  <unavailable> has name/value:  / [e-mail]  LoginManagerContent.jsm:802
13:58:53.398 Password field <unavailable> has name:    LoginManagerContent.jsm:810
13:58:53.399 form not filled, the password field was already filled  LoginManagerContent.jsm:1148
13:58:53.400 _fillForm: Attaching event listeners to usernameField  LoginManagerContent.jsm:1275
13:58:54.095 onLocationChange handled: "https://ticket.gatwickexpress.com/account/address" <unavailable>  LoginManagerContent.jsm:87
13:58:54.097 _onNavigation: state: <unavailable> loginFormRootElements size: 1 document: <unavailable>  LoginManagerContent.jsm:886
13:58:54.099 _onFormSubmit <unavailable>  LoginManagerContent.jsm:912
13:58:54.102 _filterRecipesForForm <unavailable>  LoginRecipes.jsm:261
13:58:54.103 getFieldOverrides: filtered recipes: <unavailable>  LoginRecipes.jsm:286
13:58:54.103 Username field  <unavailable> has name/value:  / [e-mail]  LoginManagerContent.jsm:802
13:58:54.105 Password field <unavailable> has name:    LoginManagerContent.jsm:810
13:58:54.124 nsLoginManager:Checking if logins to "https://ticket.gatwickexpress.com" can be saved.  nsLoginManager.js:439
13:58:54.125 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:54.142 Login storage:_searchLogins: returning 1 logins for Object { hostname: "https://ticket.gatwickexpress.com", formSubmitURL: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:54.149 LoginManagerParent:Found an existing login matching this form submission  LoginManagerParent.jsm:400
13:58:54.153 LoginManagerParent:...passwords differ, prompting to change.  LoginManagerParent.jsm:404
13:58:54.154 LoginManagerPrompter:===== initialized =====  nsLoginManagerPrompter.js:751
13:58:54.155 LoginManagerPrompter:promptToChangePassword  nsLoginManagerPrompter.js:1240
13:58:54.408 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:54.413 Login storage:_searchLogins: returning 1 logins for Object { httpRealm: null, formSubmitURL: "https://ticket.gatwickexpress.com", hostname: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:55.141 onLocationChange handled: "https://ticket.gatwickexpress.com/account/payment" <unavailable>  LoginManagerContent.jsm:87
13:58:55.142 _onNavigation: state: <unavailable> loginFormRootElements size: 1 document: <unavailable>  LoginManagerContent.jsm:886
13:58:55.143 _onFormSubmit <unavailable>  LoginManagerContent.jsm:912
13:58:55.144 _filterRecipesForForm <unavailable>  LoginRecipes.jsm:261
13:58:55.144 getFieldOverrides: filtered recipes: <unavailable>  LoginRecipes.jsm:286
13:58:55.144 Username field  <unavailable> has name/value:  / [e-mail]  LoginManagerContent.jsm:802
13:58:55.145 Password field <unavailable> has name:    LoginManagerContent.jsm:810
13:58:55.148 nsLoginManager:Checking if logins to "https://ticket.gatwickexpress.com" can be saved.  nsLoginManager.js:439
13:58:55.149 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:55.157 Login storage:_searchLogins: returning 1 logins for Object { hostname: "https://ticket.gatwickexpress.com", formSubmitURL: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:55.161 LoginManagerParent:Found an existing login matching this form submission  LoginManagerParent.jsm:400
13:58:55.162 LoginManagerParent:...passwords differ, prompting to change.  LoginManagerParent.jsm:404
13:58:55.162 LoginManagerPrompter:===== initialized =====  nsLoginManagerPrompter.js:751
13:58:55.162 LoginManagerPrompter:promptToChangePassword  nsLoginManagerPrompter.js:1240
13:58:55.452 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:55.464 Login storage:_searchLogins: returning 1 logins for Object { httpRealm: null, formSubmitURL: "https://ticket.gatwickexpress.com", hostname: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:55.951 onLocationChange handled: "https://ticket.gatwickexpress.com/account/evouchers" <unavailable>  LoginManagerContent.jsm:87
13:58:55.952 _onNavigation: state: <unavailable> loginFormRootElements size: 1 document: <unavailable>  LoginManagerContent.jsm:886
13:58:55.953 _onFormSubmit <unavailable>  LoginManagerContent.jsm:912
13:58:55.953 _filterRecipesForForm <unavailable>  LoginRecipes.jsm:261
13:58:55.954 getFieldOverrides: filtered recipes: <unavailable>  LoginRecipes.jsm:286
13:58:55.954 Username field  <unavailable> has name/value:  / [e-mail]  LoginManagerContent.jsm:802
13:58:55.955 Password field <unavailable> has name:    LoginManagerContent.jsm:810
13:58:55.955 nsLoginManager:Checking if logins to "https://ticket.gatwickexpress.com" can be saved.  nsLoginManager.js:439
13:58:55.957 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:55.966 Login storage:_searchLogins: returning 1 logins for Object { hostname: "https://ticket.gatwickexpress.com", formSubmitURL: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }  storage-json.js:359
13:58:55.969 LoginManagerParent:Found an existing login matching this form submission  LoginManagerParent.jsm:400
13:58:55.969 LoginManagerParent:...passwords differ, prompting to change.  LoginManagerParent.jsm:404
13:58:55.970 LoginManagerPrompter:===== initialized =====  nsLoginManagerPrompter.js:751
13:58:55.970 LoginManagerPrompter:promptToChangePassword  nsLoginManagerPrompter.js:1240
13:58:56.343 nsLoginManager:Searching for logins  nsLoginManager.js:396
13:58:56.351 Login storage:_searchLogins: returning 1 logins for Object { httpRealm: null, formSubmitURL: "https://ticket.gatwickexpress.com", hostname: "https://ticket.gatwickexpress.com" } with options Object { schemeUpgrades: true }

Comment 1

[Matthew N. [:MattN]]

This is a known issue that affects other sites too.

We shouldn't reprompt for the save username+password combo on the same site. I believe the bug to remember the last prompt for a document landed but the code to not prompt if we already did may not have landed.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.