1409017 - Link is opened in Safari when tapping "Open Link" via 3DT Peek & Pop

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 10.0(7025)
Device: iPhone 8 Plus
iOS: 11.0.2

Steps to reproduce:
1. Go to google.com
2. Search for "bbc"
3. Force touch and swipe up on the "bbc" result via Peek & Pop
4. Tap on "Open Link"

Actual results:
- The page is opened in Safari.

Expected:
- The page should open in Firefox.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8919445 [details] [review]
GitHub Pull Request

File a follow-up to track doing something else?

Comment 3

[Justin D'Arcangelo [:justindarc]]

Follow-up in Bug 1409509.

Comment 4

[Justin D'Arcangelo [:justindarc]]

It is likely that this will be needed in v9.3 as well since the long-press gesture code has changed to match the native WKWebView behavior. The patch is also very low-risk.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on v9.x:

https://github.com/mozilla-mobile/firefox-ios/commit/c6ae1d328c1646df7bdf775a65ce8df315960996

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/32ee20bfa2ce0e7b1c7dcdcee47edda817505422

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/13cb9c5407bbaf01d275622e6b85d38a5a35a310

Comment 6

[Catalin Suciu [:csuciu]]

Verified that link preview is disabled in master 84e4a949 & beta 10.0 (7012)

Comment 7

[Catalin Suciu [:csuciu]]

Verified as fixed in v9.3 (7374)