Missing break statement from element.find_

RESOLVED WONTFIX

Status

Testing
Marionette
RESOLVED WONTFIX
a month ago
a month ago

People

(Reporter: ato, Assigned: ato)

Tracking

Version 3
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
element.find_ is missing a brbeak state in the default clause.
(Assignee)

Updated

a month ago
Assignee: nobody → ato
Blocks: 1400256
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a month ago
mozreview-review
Comment on attachment 8918874 [details]
Bug 1409026 - Add missing break statement to find_.

https://reviewboard.mozilla.org/r/189742/#review194906

As already mentioned on the other bug, I don't see why it's needed. The linter doesn't show this as failure, and default always comes last. So this is basically a no-op.
Attachment #8918874 - Flags: review?(hskupin)
(Assignee)

Comment 3

a month ago
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 8918874 [details]
> Bug 1409026 - Add missing break statement to find_.
> 
> https://reviewboard.mozilla.org/r/189742/#review194906
> 
> As already mentioned on the other bug, I don't see why it's needed. The
> linter doesn't show this as failure, and default always comes last. So this
> is basically a no-op.

A default case doesn’t always need to come last, but OK.  I will drop this.
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.