Closed Bug 1409026 Opened 6 years ago Closed 6 years ago

Missing break statement from element.find_

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Platform:
x86_64
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

Bug 1409026 - Add missing break statement to find_.
59 bytes, text/x-review-board-request
Details 
element.find_ is missing a brbeak state in the default clause.
Assignee: nobody → ato
Blocks: 1400256
Status: NEW → ASSIGNED
Comment on attachment 8918874 [details]
Bug 1409026 - Add missing break statement to find_.

https://reviewboard.mozilla.org/r/189742/#review194906

As already mentioned on the other bug, I don't see why it's needed. The linter doesn't show this as failure, and default always comes last. So this is basically a no-op.
Attachment #8918874 - Flags: review?(hskupin)
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 8918874 [details]
> Bug 1409026 - Add missing break statement to find_.
> 
> https://reviewboard.mozilla.org/r/189742/#review194906
> 
> As already mentioned on the other bug, I don't see why it's needed. The
> linter doesn't show this as failure, and default always comes last. So this
> is basically a no-op.

A default case doesn’t always need to come last, but OK.  I will drop this.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.