Closed Bug 1409056 Opened 2 years ago Closed 2 years ago

Allow beta users to manually enable Report Site Issue button

Categories

(Web Compatibility :: Tooling & Investigations, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

Attachments

(1 file)

Right now addon sources are only included for Dev Edition and Nightly, but we want to allow users who care to manually toggle a pref to get the Report Site Issue item.

http://searchfox.org/mozilla-central/source/browser/extensions/moz.build#28-29
http://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5014-5018
Priority: -- → P1
We are cautious enabling site reporting on Beta due to the volume of issues and keeping up a good SLA.

Landing it behind a pref will allow a staged rollout (and some other benefits eventually, like using it in experiments).

The proposed plan is to land this for 61 and to run a shield on beta, enabling reporting for an incremental amount of users while keeping an eye on report numbers and quality.

In conjunction, we should also land telemetry in how many clicks the feature gets to track some kind of conversion metric.
Hey Ryan, just to verify -- we don't have a define to land something as "not release" (aka, beta -> nightly), right? 

EARLY_BETA_OR_EARLIER exists, but maybe it's awkward or confusing to enable a feature that disappears partway through the beta cycle?
Flags: needinfo?(ryanvm)
We do not have a release-only define other than by checking the update channel, though that has some caveats too.
Flags: needinfo?(ryanvm)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> We do not have a release-only define other than by checking the update
> channel, though that has some caveats too.

Thanks Ryan. I think it makes sense to just let the code ride the trains, as long as it's false by default for Beta and Release, and we let the Shield experiment do the flipping.

(Nothing should happen if the pref isn't true: https://searchfox.org/mozilla-central/source/browser/extensions/webcompat-reporter/bootstrap.js#43)
Comment on attachment 8966400 [details]
Bug 1409056. Allow webcompat-reporter addon to ride the trains.

https://reviewboard.mozilla.org/r/235102/#review240928

I don't want to block this so r+, but it's unfortunate that this is going to cause code to be loaded before the browser UI for no use for most users (ie. release users). I wonder if this can be fixed when converting webcompat-reporter away from a bootstrapped extension (ie. bug 1451485).
Attachment #8966400 - Flags: review?(florian) → review+
(In reply to Florian Quèze [:florian] from comment #7) 
> I don't want to block this so r+, but it's unfortunate that this is going to
> cause code to be loaded before the browser UI for no use for most users (ie.
> release users). I wonder if this can be fixed when converting
> webcompat-reporter away from a bootstrapped extension (ie. bug 1451485).

Is there anything we could do in the short-term to mitigate any side-effects of this?
Flags: needinfo?(florian)
(In reply to Mike Taylor [:miketaylr] from comment #8)
> (In reply to Florian Quèze [:florian] from comment #7) 
> > I don't want to block this so r+, but it's unfortunate that this is going to
> > cause code to be loaded before the browser UI for no use for most users (ie.
> > release users). I wonder if this can be fixed when converting
> > webcompat-reporter away from a bootstrapped extension (ie. bug 1451485).
> 
> Is there anything we could do in the short-term to mitigate any side-effects
> of this?

It's a cost we are paying for each system add-on (they are all loaded at startup when the add-on manager starts), so we could reduce it by reducing the number of system add-ons. In this case we could merge webcompat-reporter into webcompat. I'm not sure why they are 2 different add-ons, if it was just so that a part of the code was shipped to only the nightly population, then shipping it to everybody means it's time to merge the two.

That said, I don't expect the startup performance difference to be significant enough to be visible on Talos or Telemetry (or I wouldn't have r+'ed).
Flags: needinfo?(florian)
OK, thanks. I think long-term it makes sense to merge the addons.
Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32ae04d4e132
Allow webcompat-reporter addon to ride the trains. r=florian
https://hg.mozilla.org/mozilla-central/rev/32ae04d4e132
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee: nobody → miket
See Also: → 1488929
You need to log in before you can comment on or make changes to this bug.