Include the generated WebIDL and IPDL source files in Eclipse CDT

RESOLVED FIXED in Firefox 58

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We add some include paths to headers that are generated in the object directory, but Eclipse has no knowledge about source files that are generated in the object directory. This is a real pain for anyone wanting to interact with WebIDL or IPDL generated content (follow call graphs through such content for example).

We could possibly add the entire object directory as a linked resource, but I'm not sure we want Eclipse to worry about anything else in the object directory. Probably the best thing to do is just to link these two directories in.
FYI in bug 1384568 I made the common backend output a JSON file of generated sources for use in bug 1259832. You might find that useful for this purpose.
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> FYI in bug 1384568 I made the common backend output a JSON file of generated
> sources for use in bug 1259832. You might find that useful for this purpose.

Thanks for pointing that out.

Many of the files that are generated are header files. In fact there are only two non-header source files that are not under $OBJDIR/dom/bindings and $OBJDIR/ipc/ipdl:

 * security/nss/lib/ckfw/builtins/builtins_nssckbi/certdata.c
 * accessible/xpcom/xpcAccEvents.cpp

which is why I only included dom/bindings and ipc/ipdl in this patch.

A patch that parses $OBJDIR/generated-sources.json, ignores directories that only have generated headers, and creates resource links for directories containing source files would certainly be more robust. I think I'll punt on that to a follow-up bug though since right now I'm needing to unblock myself rather than create more work and this patch catches 99.9% of the generated source files.
Comment on attachment 8919007 [details]
Bug 1409121 - Include the generated WebIDL and IPDL source files in Eclipse CDT.

https://reviewboard.mozilla.org/r/189898/#review195024

Thanksk for fixing this!
Attachment #8919007 - Flags: review?(botond) → review+

Comment 5

a year ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2681f1bd9e41
Include the generated WebIDL and IPDL source files in Eclipse CDT. r=botond DONTBUILD NPOTB
(Assignee)

Updated

a year ago
Blocks: 1409194
https://hg.mozilla.org/mozilla-central/rev/2681f1bd9e41
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.