1409121 - Include the generated WebIDL and IPDL source files in Eclipse CDT

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Jonathan Watt [:jwatt]]

We add some include paths to headers that are generated in the object directory, but Eclipse has no knowledge about source files that are generated in the object directory. This is a real pain for anyone wanting to interact with WebIDL or IPDL generated content (follow call graphs through such content for example).

We could possibly add the entire object directory as a linked resource, but I'm not sure we want Eclipse to worry about anything else in the object directory. Probably the best thing to do is just to link these two directories in.

Comment 1

[(not currently active) Ted Mielczarek]

FYI in bug 1384568 I made the common backend output a JSON file of generated sources for use in bug 1259832. You might find that useful for this purpose.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1409121 - Include the generated WebIDL and IPDL source files in Eclipse CDT.

Review commit: https://reviewboard.mozilla.org/r/189898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189898/

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> FYI in bug 1384568 I made the common backend output a JSON file of generated
> sources for use in bug 1259832. You might find that useful for this purpose.

Thanks for pointing that out.

Many of the files that are generated are header files. In fact there are only two non-header source files that are not under $OBJDIR/dom/bindings and $OBJDIR/ipc/ipdl:

 * security/nss/lib/ckfw/builtins/builtins_nssckbi/certdata.c
 * accessible/xpcom/xpcAccEvents.cpp

which is why I only included dom/bindings and ipc/ipdl in this patch.

A patch that parses $OBJDIR/generated-sources.json, ignores directories that only have generated headers, and creates resource links for directories containing source files would certainly be more robust. I think I'll punt on that to a follow-up bug though since right now I'm needing to unblock myself rather than create more work and this patch catches 99.9% of the generated source files.

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8919007 [details]
Bug 1409121 - Include the generated WebIDL and IPDL source files in Eclipse CDT.

https://reviewboard.mozilla.org/r/189898/#review195024

Thanksk for fixing this!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2681f1bd9e41
Include the generated WebIDL and IPDL source files in Eclipse CDT. r=botond DONTBUILD NPOTB

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2681f1bd9e41