Closed Bug 1409215 Opened 7 years ago Closed 7 years ago

don't change scroll thumbs into AGRs during display list building

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

      No description provided.
Attached patch scrollthumbSplinter Review
Attachment #8919094 - Flags: review?(mstange)
Comment on attachment 8919094 [details] [diff] [review]
scrollthumb

Review of attachment 8919094 [details] [diff] [review]:
-----------------------------------------------------------------

The comment seems to be the only difference compared to part 15 in bug 1404181 which I just reviewed earlier today, so this was an easy re-review.

::: layout/painting/nsDisplayList.cpp
@@ +1580,5 @@
> +    nsIScrollableFrame* sf = static_cast<nsSliderFrame*>(parent)->GetScrollFrame();
> +    // The word "Maybe" in IsMaybeScrollingActive might be confusing but we do
> +    // indeed need to always consider scroll thumbs as AGRs if
> +    // IsMaybeScrollingActive is true because that is the same condition we use
> +    // in ScrollFrameHelper::AppendScrollPartsTo to layerizer scroll thumbs.

layerizer -> layerize
Attachment #8919094 - Flags: review?(mstange) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d3d17327436
Don't change scroll thumbs into AGRs during display list building. r=mstange
https://hg.mozilla.org/mozilla-central/rev/7d3d17327436
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: