1409258 - Resolve -Wnarrowing warnings inside dom/plugins

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Tom Ritter [:tjr] (OOTO until April)]

>  /builds/worker/workspace/build/src/dom/plugins/ipc/PluginInstanceChild.cpp:3315:21: error: narrowing conversion of '((mozilla::plugins::PluginInstanceChild*)this)->mozilla::plugins::PluginInstanceChild::mWindow._NPWindow::width' from 'uint32_t {aka unsigned int}' to 'int' inside { } [-Werror=narrowing]
>               mWindow.width, mWindow.height,
>               ~~~~~~~~^~~~~
>  /builds/worker/workspace/build/src/dom/plugins/ipc/PluginInstanceChild.cpp:3315:36: error: narrowing conversion of '((mozilla::plugins::PluginInstanceChild*)this)->mozilla::plugins::PluginInstanceChild::mWindow._NPWindow::height' from 'uint32_t {aka unsigned int}' to 'int' inside { } [-Werror=narrowing]
>               mWindow.width, mWindow.height,
>                              ~~~~~~~~^~~~~~
>  /builds/worker/workspace/build/src/dom/plugins/ipc/PluginInstanceChild.cpp:3320:13: error: narrowing conversion of '(LPARAM)(& winpos)' from 'LPARAM {aka long int}' to 'uintptr_t {aka unsigned int}' inside { } [-Werror=narrowing]
>               (LPARAM) &winpos
>               ^~~~~~~~~~~~~~~~




For width and height, it seems like these are initialized from a function or member of type int but stored as uints:
http://searchfox.org/mozilla-central/source/layout/generic/nsPluginFrame.cpp#582
http://searchfox.org/mozilla-central/source/layout/generic/nsPluginFrame.cpp#660

I think I can go through and make them uints, does that sound good?

Comment 1

[Jim Mathies [:jimm]]

You don't want to modify NSWindow but if you want to touch up the conversion seems fine.

http://searchfox.org/mozilla-central/source/dom/plugins/base/npapi.h#514

Comment 2

[Tom Ritter [:tjr] (OOTO until April)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dbfa2b8f8c097e0ecc30d7a8cb480b585aee1e6

Comment 3

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: Bug 1409258 Adjust the definition of NPEvent and resolve uint -> int narrowing in dom/plugins

lParam is a long int (signed) while wparam is unsigned. Correct lParam to be an intptr

Review commit: https://reviewboard.mozilla.org/r/190228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190228/

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8919379 [details]
Bug 1409258 Adjust the definition of NPEvent and resolve uint -> int narrowing in dom/plugins

https://reviewboard.mozilla.org/r/190228/#review195530

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73c16ac04291
Adjust the definition of NPEvent and resolve uint -> int narrowing in dom/plugins r=jimm

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/73c16ac04291