|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
This is preparatory work to later use RAII for mutexes.
Comment on attachment 8919171 [details] Bug 1409273 - Replace malloc_mutex_* with class methods. https://reviewboard.mozilla.org/r/190082/#review195328 r=me with the issue below fixed. ::: memory/build/mozjemalloc.cpp:3900 (Diff revision 1) > unsigned i; > arena_bin_t* bin; > size_t prev_run_size; > > - if (malloc_mutex_init(&mLock)) > + if (mLock.Init()) > return true; You inverted the sense of Mutex::Init()'s return value so you need to invert this condition. And then you could likewise invert the sense of arena_t::Init()'s return value (and its call sites!)
I'll leave arena_t::Init for a followup.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2d93b4fb4b17 Replace malloc_mutex_* with class methods. r=njn