1409274 - Remove the lock for SourceBufferTaskQueue

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Alastor Wu [:alwu]]

It would only be accessed on task queue now, so we don't need to lock it.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1409274 - remove the lock for SourceBufferTaskQueue.

It would only be accessed on task queue now, so we don't need to lock it.

Review commit: https://reviewboard.mozilla.org/r/190078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190078/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8919170 [details]
Bug 1409274 - remove the lock for SourceBufferTaskQueue.

https://reviewboard.mozilla.org/r/190078/#review195308

::: dom/media/mediasource/TrackBuffersManager.h:38
(Diff revision 1)
>  class SourceBufferResource;
>  
>  class SourceBufferTaskQueue
>  {
>  public:
>    SourceBufferTaskQueue()

SourceBufferTaskQueue() { }

Comment 3

[Alastor Wu [:alwu]]

Thanks for review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=533c2aef6670306f8a3d2ddb8757a3a5af47a643

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8919170 [details]
Bug 1409274 - remove the lock for SourceBufferTaskQueue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190078/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64a75a906b5d
remove the lock for SourceBufferTaskQueue. r=jya

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/64a75a906b5d