1409348 - Prefer the per-provider report{Malware,Phish}MistakeURL in the updated about:blocked page

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Hector Zhao [:hectorz]]

Attachment: Screenshot of a phishing url blocked by non-google provider

(In reply to Hector Zhao [:hectorz] from bug 1363051 comment #66)
> (In reply to François Marier [:francois] from bug 1363051 comment #3)
> > (In reply to :prathiksha from bug 1363051 comment #2)
> > > What links are we going to provide for "reported as a deceptive site" and
> > > "report a detection problem" here(https://cl.ly/133s093C2A3x) ? :)
> > 
> > The URLs are in https://bugzilla.mozilla.org/show_bug.cgi?id=1358536#c13:
> > 
> > -
> > https://www.google.com/transparencyreport/safebrowsing/diagnostic/index.
> > html?#url=http://testsafebrowsing.appspot.com/s/malware.html (phishing,
> > malware and unwanted)
> > - https://safebrowsing.google.com/safebrowsing/report_error/?tpl=mozilla
> > (phishing)
> > - https://www.stopbadware.org/firefox (malware)
> > ...
> 
> Sorry I didn't notice this earlier, but shouldn't we use the per-provider
> reportMalwareMistakeURL/reportPhishMistakeURL here?

Please see the attached screenshot (in Chinese), when defining additional Safe Browsing provider with the "browser.safebrowsing.provider.*" prefs, a phishing url is successfully blocked, and the correct provider is identified in the advisory part. However the "report a detection problem" link was hard-coded to the Google one.

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Bug 1409348 - Prefer the per-provider report{Malware,Phish}MistakeURL in about:blocked.

Review commit: https://reviewboard.mozilla.org/r/190150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190150/

Comment 2

[François Marier [:francois]]

Comment on attachment 8919252 [details]
Bug 1409348 - Prefer the per-provider report{Malware,Phish}MistakeURL in about:blocked.

https://reviewboard.mozilla.org/r/190150/#review195600

Comment 3

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a544c88ddd4e

Failures in Bs/Fxfn-r-e10s/bc6 are more likely a result of the artifact build than this change.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f637f40c7404
Prefer the per-provider report{Malware,Phish}MistakeURL in about:blocked. r=francois

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f637f40c7404

Comment 6

[Julien Cristau [:jcristau]]

This doesn't sound like a must fix for 57.