Closed Bug 1409359 Opened 7 years ago Closed 6 years ago

Permaorange test-verify browser/components/preferences/in-content/tests/browser_extension_controlled.js | Test timed out -

Categories

(Firefox :: Settings UI, defect, P5)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mstriemer)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

Bug 1409359 - Cleanup installed add-on in testExtensionControlledNewTab
59 bytes, text/x-review-board-request
bsilverberg
: review+
aswan
: review+
Details 
Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=137402915&repo=autoland

https://queue.taskcluster.net/v1/task/CD8uWLUuSTiYxSF6N8FOYg/runs/0/artifacts/public/test_info//browser-chrome_errorsummary.log

Test Verify runs modified tests several times to check for issues with modified tests.

This test always fails if run more than once (== during the second test run).

[task 2017-10-17T04:40:58.354Z] 04:40:58     INFO - Entering test bound testExtensionControlledNewTab
[task 2017-10-17T04:40:58.354Z] 04:40:58     INFO - Buffered messages logged at 04:40:15
[task 2017-10-17T04:40:58.355Z] 04:40:58     INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #general should be in the URI for about:preferences - 
[task 2017-10-17T04:40:58.355Z] 04:40:58     INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | new tab is not set - 
[task 2017-10-17T04:40:58.356Z] 04:40:58     INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden - 
[task 2017-10-17T04:40:58.356Z] 04:40:58     INFO - Buffered messages finished
[task 2017-10-17T04:40:58.357Z] 04:40:58     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Test timed out -
37 failures in the last 3 days:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1409359

on all configurations it looks like (windows, osx, linux- opt/pgo/debug).

here is a recent win10 debug log:
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=139699461&lineNumber=2300

and the related screenshot:
https://public-artifacts.taskcluster.net/difS6ZHBRLCTe1lZfU1l2g/0/public/test_info/mozilla-test-fail-screenshot_35meje.png

and related text near the failure:
2:07:56     INFO -  66 INFO Leaving test bound testPrefLockedHomepage
02:07:56     INFO -  67 INFO Entering test bound testExtensionControlledNewTab
02:07:56     INFO -  Buffered messages logged at 02:06:33
02:07:56     INFO -  68 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #general should be in the URI for about:preferences -
02:07:56     INFO -  69 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | new tab is not set -
02:07:56     INFO -  70 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
02:07:56     INFO -  Buffered messages finished
02:07:56    ERROR -  71 INFO TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Test timed out -
02:07:56     INFO -  GECKO(7764) | MEMORY STAT | vsize 1886MB | vsizeMaxContiguous 132540277MB | residentFast 304MB | heapAllocated 71MB
02:07:56     INFO -  72 INFO TEST-OK | browser/components/preferences/in-content/tests/browser_extension_controlled.js | took 90078ms
02:07:56     INFO -  Not taking screenshot here: see the one that was previously logged
02:07:56    ERROR -  73 INFO TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Found a tab after previous test timed out: about:preferences#general -


:mattn, can you look into this?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell needswork]
this is caused by the landing of bug 1386018
Depends on: 1386018
Initial failures were triggered by a change to the test in bug 1407999, but since test-verify is new, we don't know if this is just an indication of a pre-existing condition.

Recent failures were triggered by a change to the test in bug 1386018, but again, that's likely not to blame.
This issue is easily reproduced locally with:

  mach mochitest browser/components/preferences/in-content/tests/browser_extension_controlled.js --repeat 2

It looks to me like the test balances calls to lockPrefs() and unlockPrefs() and unlockPrefs() seems to attempt to restore the original state, but the failure suggests that doesn't quite work for the home page.

:mstriemer -- This looks like something you might understand?
Flags: needinfo?(MattN+bmo) → needinfo?(mstriemer)
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Flags: needinfo?(mstriemer)
Comment on attachment 8922438 [details]
Bug 1409359 - Cleanup installed add-on in testExtensionControlledNewTab

https://reviewboard.mozilla.org/r/193484/#review198718

This looks fine to me. Just checking, are we landing these patches with only an r+ from me? I'm not sure that's kosher as I'm not a WebExtensions peer.
Attachment #8922438 - Flags: review?(bob.silverberg) → review+
Attachment #8922438 - Flags: review?(aswan)
Okay, r? aswan too
Comment on attachment 8922438 [details]
Bug 1409359 - Cleanup installed add-on in testExtensionControlledNewTab

https://reviewboard.mozilla.org/r/193484/#review198812
Attachment #8922438 - Flags: review?(aswan) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/05a8206ba584
Cleanup installed add-on in testExtensionControlledNewTab r=aswan,bsilverberg
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/05a8206ba584
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=166513547&repo=mozilla-inbound&lineNumber=15845
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: