Closed Bug 1409363 Opened 3 years ago Closed 3 years ago

Can't move bookmarks in library

Categories

(Firefox :: Bookmarks & History, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- disabled
firefox57 --- disabled
firefox58 --- verified

People

(Reporter: hani.yacoub, Assigned: standard8)

References

Details

(Keywords: dataloss, regression, Whiteboard: [fxsearch])

Attachments

(2 files)

Attached video Move bookmarks.mp4
[Affected versions]: 
Nightly 58.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Open Firefox and go visit some websites and bookmark them.
2. Go to Bookmarks -> Show All Bookmarks.
3. Go to Bookmarks Toolbar and select the bookmarked websites.
4. Click on "Organize" and the on "Move...".
5. Select Other bookmarks and click on "OK".

[Expected result]:
Bookmarks are correctly moved.

[Actual result]:
Bookmarks are not moved to Other Bookmarks.
Any error reported to the Browser Console?
Keywords: regression
Priority: -- → P1
Whiteboard: [fxsearch]
I didn't see any errors in the browser console.
I see this as well, it doesn't happen with async transactions disabled.
Assignee: nobody → standard8
Blocks: 1404267
Keywords: dataloss
The interesting thing is this works for moving from a top-level folder to a sub-folder (we have an automated test for that, and I tested manually), but doesn't seem to work moving across the main folders.

I'll do some more poking.
Status: NEW → ASSIGNED
could be lack of a concreteGetItemGuid somewhere, maybe it's trying to move something to a folder shortcut, instead of moving it into the pointed at folder.
I can confirm this issue,
workaround is to restart Firefox and move bookmark again.
Comment on attachment 8920570 [details]
Bug 1409363 - Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid.

https://reviewboard.mozilla.org/r/191586/#review196840
Attachment #8920570 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4725574d6f27
Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid. r=mak
https://hg.mozilla.org/mozilla-central/rev/4725574d6f27
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Build ID: 20171022220103
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.