1409363 - Can't move bookmarks in library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: Move bookmarks.mp4

[Affected versions]: 
Nightly 58.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Open Firefox and go visit some websites and bookmark them.
2. Go to Bookmarks -> Show All Bookmarks.
3. Go to Bookmarks Toolbar and select the bookmarked websites.
4. Click on "Organize" and the on "Move...".
5. Select Other bookmarks and click on "OK".

[Expected result]:
Bookmarks are correctly moved.

[Actual result]:
Bookmarks are not moved to Other Bookmarks.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Any error reported to the Browser Console?

Comment 2

[Hani Yacoub, Desktop QA]

I didn't see any errors in the browser console.

Comment 3

[Mark Banner (:standard8)]

I see this as well, it doesn't happen with async transactions disabled.

Comment 4

[Mark Banner (:standard8)]

The interesting thing is this works for moving from a top-level folder to a sub-folder (we have an automated test for that, and I tested manually), but doesn't seem to work moving across the main folders.

I'll do some more poking.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

could be lack of a concreteGetItemGuid somewhere, maybe it's trying to move something to a folder shortcut, instead of moving it into the pointed at folder.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can confirm this issue,
workaround is to restart Firefox and move bookmark again.

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1409363 - Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid.

Review commit: https://reviewboard.mozilla.org/r/191586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191586/

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8920570 [details]
Bug 1409363 - Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid.

https://reviewboard.mozilla.org/r/191586/#review196840

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4725574d6f27
Fix moving bookmarks to a top-level folder via the move bookmarks dialog - use concreteItemGuid to get the correct guid. r=mak

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4725574d6f27

Comment 11

[Hani Yacoub, Desktop QA]

Build ID: 20171022220103
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.