1409370 - [10.13] Closing new email notification still opens the email

Status: RESOLVED WORKSFORME

(Thunderbird :: OS Integration, defect)

Description

[scottishwildcat]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Safari/604.1.38

Steps to reproduce:

When a new email arrives, click the "Close" button in the native macOS notification that appears.


Actual results:

The notification is dismissed, but the corresponding email is also opened, full-screen.


Expected results:

The email should only be opened when clicking in the body of the notification. When clicking the Close button, the notification should simply be dismissed.

Comment 1

[scottishwildcat]

(Note I'm reporting this bug against Thunderbird running in macOS 10.13 on my MacBook... *not* the machine whose details are reported in my original comment.)

Comment 2

[Jorg K (CEST = GMT+2)]

Something for Richard to try on his new Mac ;-)

Comment 3

[Richard Marti (:Paenglab)]

Scottishwildcat, please can you attach a screenshot of the notification with its close button (see above the 'attach file' link)?

I see no close button, so for me it's clear the message will be opened because every click on the notification means 'show message'.

Also Apple Mail has no close button on the notification -> no close button on notification is system standard and, if you can't show me the button, this bug invalid.

Comment 4

[Jorg K (CEST = GMT+2)]

But there's a close button on Windows, right?

Comment 5

[scottishwildcat]

Attachment: Thunderbird notification with Close button

Here's the Thunderbird notification. Note that notification type for Thunderbird has to be set to "Alert" rather than "Banner" in macOS Notifications System Preferences, for the button to appear.

Comment 6

[scottishwildcat]

Also, Apple Mail has both Close and Reply buttons on its notifications -- again provided you've set the notification type to "Alert".

https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/Product_Help/en_US/PUBLIC_USERS/PL124/S0855_ReceiveNotifications.png

Comment 7

[Richard Marti (:Paenglab)]

The screenshot is from OSX 10.13?

Comment 8

[scottishwildcat]

Yep, just took it myself.

Comment 9

[scottishwildcat]

(The Thunderbird one that is... the Apple one is from a support article, but I've always had buttons in my Apple Mail notifications.)

Comment 10

[Richard Marti (:Paenglab)]

Ah yes, there is the possibility between a banner and the notification in system settings.

Unfortunately we have no developer on Mac who could fix this.

Comment 11

[scottishwildcat]

That's unfortunate, especially as it's always worked fine up until 10.13 :/

Comment 12

[Richard Marti (:Paenglab)]

If you could reproduce it with Firefox we would have the chance it would be fixed as we use shared code from Firefox.

Comment 13

[scottishwildcat]

Interesting... I'll see what I can do.

Comment 14

[scottishwildcat]

Unfortunately, the buttons on any Firefox notifications I've managed to conjur up appear to work as expected :/

Comment 15

[Richard Marti (:Paenglab)]

Philipp, hopefully you can help because you're working mainly on Mac.

It seems, something in https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessengerOSXIntegration.mm needs a change to work with macOS 10.13. Would you know what is needed to fix?

Comment 16

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This is a bug or missing feature in nsIAlertsService, the same thing happens in Firefox with this code:

var as = Components.classes["@mozilla.org/alerts-service;1"].getService(Components.interfaces.nsIAlertsService);

var listener = {
  observe: function(subject, topic, data) {
    alert("TOPIC: " + topic + " - " + subject + " - " + data);
  }
}
as.showAlertNotification("", "title", "text", true, "cookie", listener, "", "auto", "", "", null, false, false )


Running this code, you get an "alertclickcallback" notification both when the close button is clicked and the text is clicked. There is no way to differentiate them in the observer notification.

Path forward would be to file a bug in Toolkit :: Notifications and Alerts to allow differentiating the two, then we can take action in Thunderbird.

Comment 17

[Richard Marti (:Paenglab)]

10.13.1 is out now. I tested the notification and they work now again.