Closed
Bug 1409398
Opened 8 years ago
Closed 8 years ago
EnumSet: Remove initVersion and the calls to it
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
To quote Nathan in https://bugzilla.mozilla.org/show_bug.cgi?id=1409382#c3
Shall we just remove this method and all the calls to it as well? It looks like forgetting to call this method in the `EnumSet(T)` constructor was the source of the problem...but adding an initializer as is done below means that this method is redundant now.
|
Assignee | |
Comment 1•8 years ago
|
||
We don't need this function anymore with member initializer syntax.
Attachment #8922350 -
Flags: review?(sledru)
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → nfroyd
|
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8922350 [details] [diff] [review]
remove EnumSet::initVersion
lgtm, thanks!
Attachment #8922350 -
Flags: review?(sledru) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/139a288d11d3
remove EnumSet::initVersion; r=sylvestre
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•