1409433 - menus.onClicked listener error when invoked from sidebar/browser-action page

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[slemmer.balazs]

Attachment: Example context menu and listener creation

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171003101214

Steps to reproduce:

Click on a context menu of an extension from a sidebar or browser-action page. The context menu and the listener is created according to the attachment.


Actual results:

The following error was logged to the extension debugging console:

TypeError: WeakMap key must be an object, got null  ext-browser.js:250:5


Expected results:

No error should have occured, and the listener function should have logged its arguments to the console.

Comment 1

[Andy McKay]

Might be something you know how to fix zombie?

Comment 2

[Tomislav Jovanovic :zombie]

Yeah, will investigate.

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1409433 - Handle contextmenu clicks in non-tab content

Review commit: https://reviewboard.mozilla.org/r/195562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195562/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8924325 [details]
Bug 1409433 - Handle contextmenu clicks in non-tab content

https://reviewboard.mozilla.org/r/195562/#review200840

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/759c687e02d2
Handle contextmenu clicks in non-tab content r=aswan

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/759c687e02d2

Comment 7

[Victor Carciu]

Verified as fixed using Build identifier: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0. Please see console logs comparison between FF57 and FF58. 
Also, please note that if you test on Windows , extensions.webextensions.remote should be set to false since on Linux(where it was reported) this is false by default.

Comment 8

[Victor Carciu]

Attachment: Postfix screenshot - FF57 vs FF58 console logs