Closed Bug 1409545 Opened 3 years ago Closed 3 years ago

Interceptor should resolve IUnknown outparams to expected interface when possible

Categories

(Core :: IPC: MSCOM, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

(Whiteboard: aes+)

Attachments

(1 file)

If we have an interface that declares a method with IUnknown outparams, we should have a way to convert that IUnknown to the interface that is eventually expected by the handler.

Currently we get a mismatch and the handler gets confused.
Attached patch FixSplinter Review
If there is a handler provider and we encounter an IUnknown outparam, we query the provider for the expected IID.
Attachment #8919478 - Flags: review?(jmathies)
Comment on attachment 8919478 [details] [diff] [review]
Fix

Review of attachment 8919478 [details] [diff] [review]:
-----------------------------------------------------------------

sorry for the delay. lgtm.
Attachment #8919478 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e18338742e1718582409afba8c0b5e7a633137ff
Bug 1409545: Add the ability to query a handler provider for the expected interface for an IUnknown outparam; r=jimm
https://hg.mozilla.org/mozilla-central/rev/e18338742e17
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.