1409596 - Don't pass input word as context data for matching XUL tree pseudos

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

Currently in Gecko, we pass input word as context data for matching XUL tree pseudos. Implementing this mechanism seems to be troublesome in Stylo (see bug 1397644 comment 3).

Since we already depend on frame being created in this case, we can probably just get the array via the element.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

So, this is probably not doable either, or at least it would be very hacky, because we can be calling into resolving tree pseudo style during early stage of frame initialization when the frame hasn't become the primary frame of element.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Maybe we can still try this... it seems that when trying to resolve style in early stage of frame initialization, mScratchArray is always cleared. We can assert that somewhere and use the element to query.

Actually it seems to me that the whole design of mScratchArray is quite inefficient...

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Alternatively we can put the pointer of the array to some global variable... (which is rather ugly...)