1409619 - Signed/Unsigned warnings in TSFTextStore

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Tom Ritter [:tjr]]

>  In file included from /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp:8:0:
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.h: In member function 'bool mozilla::widget::TSFTextStore::WasTextInsertedWithoutCompositionAt(ULONG, ULONG) const':
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.h:716:49: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>              pendingPreLastAction.mSelectionStart == aStart;
>              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp: In member function 'virtual HRESULT mozilla::widget::TSFTextStore::GetACPFromPoint(TsViewCookie, const POINT*, DWORD, LONG*)':
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp:4117:0: note: -Wmisleading-indentation is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers
>     if (NS_WARN_IF(offset > LONG_MAX)) {
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp: In member function 'HRESULT mozilla::widget::TSFTextStore::RecordCompositionStartAction(ITfCompositionView*, ULONG, ULONG, bool)':
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp:4830:0: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>     } else if (selectionForTSF.MinOffset() != aStart ||
>  /builds/worker/workspace/build/src/widget/windows/TSFTextStore.cpp:4831:0: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>                selectionForTSF.MaxOffset() != aStart + aLength) {
>  cc1plus: all warnings being treated as errors

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1409619 Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore

The functions changed are given signed arguments (that are converted to unsigned).
Changing them to signed resolves the warnings and preserves the original values.

Review commit: https://reviewboard.mozilla.org/r/190452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190452/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8919590 [details]
Bug 1409619 Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190452/diff/1-2/

Comment 3

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6171c27722a83897941066861215a17e211f2912

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8919590 [details]
Bug 1409619 Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore

https://reviewboard.mozilla.org/r/190452/#review196048

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77edd9d74149
Resolve signed/unsigned comparison warning by fixing function definitions to be signed in widget/windows/TSFTextStore r=jimm

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/77edd9d74149