1409620 - inline function used but not defined in KeyboardLayout.cpp

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

>  In file included from /builds/worker/workspace/build/src/widget/windows/nsNativeDragTarget.cpp:18:0,
>                   from /builds/worker/workspace/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows2.cpp:38:
>  /builds/worker/workspace/build/src/widget/windows/KeyboardLayout.h: At global scope:
>  /builds/worker/workspace/build/src/widget/windows/KeyboardLayout.h:205:0: error: inline function 'char16_t mozilla::widget::VirtualKey::GetCompositeChar(mozilla::widget::VirtualKey::ShiftState, char16_t) const' used but never defined [-Werror]
>     inline char16_t GetCompositeChar(ShiftState aShiftState,
>  cc1plus: all warnings being treated as errors

A few of these popup everywhere KeyboardLayout.h is included.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1409620 Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout

inline functions are supposed to be declared in the header file, so the compiler can inline them.
gcc complains about this, but clang/msvc apparently do not.

Review commit: https://reviewboard.mozilla.org/r/190460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190460/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8919592 [details]
Bug 1409620 Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190460/diff/1-2/

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=102ab2c98b86c93401b7dfb5c70e4d4f2c854a55&selectedJob=137798912

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8919592 [details]
Bug 1409620 Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout

https://reviewboard.mozilla.org/r/190460/#review196050

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95d7bf09b270
Move definition of inline function from .cpp to .h in widget/windows/KeyboardLayout r=jimm

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/95d7bf09b270