1409624 - EMULATOR is invalid when using Android Tools 26

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1409624 - Cannot detect valid emulator command when using Android Tools 26.

Although there is emulator command in android_sdk_root/tools even if Android
Tools 26, it doesn't work well becasue emulator64-arm is missing in same
directory.

Valild emulator command moves from android_sdk_root/tools to
android_sdk_root/emulator from Android Tools 26 (updated by sdkmanager).

Review commit: https://reviewboard.mozilla.org/r/190464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190464/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8919594 [details]
Bug 1409624 - Cannot detect valid emulator command when using Android Tools 26.

https://reviewboard.mozilla.org/r/190464/#review195952

This looks good -- if it works for you and gbrown, it works for me.

::: commit-message-f78d5:4
(Diff revision 1)
> +Bug 1409624 - Cannot detect valid emulator command when using Android Tools 26. r?nalexander
> +
> +Although there is emulator command in android_sdk_root/tools even if Android
> +Tools 26, it doesn't work well becasue emulator64-arm is missing in same

nit: s/becasue/because/

Comment 3

[Geoff Brown [:gbrown]]

Can we push this? It looks good to me and is required to resolve bug 1390606.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc365b8b1096
Cannot detect valid emulator command when using Android Tools 26. r=nalexander

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fc365b8b1096

Comment 6

[Geoff Brown [:gbrown]]

Thanks!