1409684 - WebAudio devtools display wonky lines

Status: VERIFIED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Andreas Pehrson [:pehrsons]]

Attachment: devtools_webaudio.png

STR
Open the WebAudio devtools tab
Go to http://webaudioapi.com/samples/crossfade/
Click Play/Pause

Expected:
Thin neat lines between WebAudio nodes

Actual:
The curved lines do not have a consistent width. See the attached screenshot.


Also, the browser console displays a warning:
> Unexpected value strokewidth parsing markerUnits attribute.  d3.js:589:6

That line in d3.js doesn't look so interesting, but the message gives you a good hint of what to look for.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1409684 - Polish d3 graphs style.

Review commit: https://reviewboard.mozilla.org/r/190782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190782/

Comment 2

[Andreas Pehrson [:pehrsons]]

I see this in 56 as well.

Comment 3

[Tim Nguyen :ntim]

:bgrins, the text color has been changed, because the --theme-body-color-alt color has been changed to light gray with the photon redesign, which makes the nodes look disabled.

The memory tool isn't affected, fill: none; is already set there.

Comment 4

[Tim Nguyen :ntim]

I regressed this in bug 1301624.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8919841 [details]
Bug 1409684 - Polish d3 graphs style.

https://reviewboard.mozilla.org/r/190782/#review195986

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3529c4890dba
Polish d3 graphs style. r=bgrins

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8919841 [details]
Bug 1409684 - Polish d3 graphs style.

Approval Request Comment
[Feature/Bug causing the regression]: this regressed since 52 in bug 1301624
[User impact if declined]: see attachment 8919681 [details]
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: only local testing so far
[Needs manual test from QE? If yes, steps to reproduce]: none
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: Not much
[Why is the change risky/not risky?]: very small CSS change
[String changes made/needed]: no

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3529c4890dba

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8919841 [details]
Bug 1409684 - Polish d3 graphs style.

Too late for 57, especially if we have this for a while... 
Will ride the train with 58

Comment 10

[Md. Majedul islam]

I have reproduced this bug with Nightly 58.0a1 (2017-10-08) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly 58.0a1.

Build ID 	20171022100058
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 11

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-10-08) on Windows 7, 64 Bit!

The fix is now verified with latest Nightly! 

Build ID 	20171022100058
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171018]

Comment 12

[Md. Majedul islam]

As per Comment 10 and Comment 11, I am marking this bug as verified fixed.