1409691 - ReferenceError: reference to undefined property "doneReason" in BackgroundPageThumbs.jsm

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mark Banner (:standard8)]

I just noticed this with strict errors turned on:

ReferenceError: reference to undefined property "doneReason" in  BackgroundPageThumbs.jsm

(ESLint also complains about it with no-unused-expressions turned on).

The section of code in question is:

http://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/toolkit/components/thumbnails/BackgroundPageThumbs.jsm#402

function Capture(url, captureCallback, options) {
  ...
  this.doneReason;
  ...
}

This looks like a missing initialisation.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1409691 - Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm).

Review commit: https://reviewboard.mozilla.org/r/201976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201976/

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8930873 [details]
Bug 1409691 - Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm).

https://reviewboard.mozilla.org/r/201976/#review207370

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adc548643541
Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm). r=Mardak

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/adc548643541