Closed Bug 1409771 Opened 4 years ago Closed 4 years ago

promiseBookmarksNotification doesn't handle skipDescendantsOnItemRemoval/skipTags in the observer it creates

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

Product:
Firefox
Component:
Bookmarks & History
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.
59 bytes, text/x-review-board-request
mak
: review+
Details 
Looking into bug 1409069, I noticed some errors being dumped out:

promiseBookmarksNotification: got skipDescendantsOnItemRemoval notification

Since skipDescendantsOnItemRemoval isn't an actual notification, but a value for observers to specify, we should really be handling it properly, not as a notification.
Status: NEW → ASSIGNED
Whiteboard: [fxsearch]
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.

https://reviewboard.mozilla.org/r/190736/#review195910

This is ok, even if we should really throw this away and use PlacesTestUtils.waitForNotification
Attachment #8919808 - Flags: review?(mak77) → review+
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.

Lets just switch to waitForNotification and get it done whilst we're here.
Attachment #8919808 - Flags: review+ → review?(mak77)
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.

https://reviewboard.mozilla.org/r/190736/#review196672

I love to see code going away!
Attachment #8919808 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cea95605332
Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly. r=mak
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/7cea95605332
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.