Revise secondary nav in Fx hub pages on mozilla.org
Christa - can you please attach the mock up for the Fx hub page secondary nav here?
Created attachment 8920348 [details] fx secondary navigation.png Minus the scribbles, this image shows the secondary navigation approved by Winston
b&w Fx logo / Desktop / Mobile / Extensions / Support / Blog
Hey, the /firefox and /mobile demo pages have a green outline vs a solid green download button within the nav. Just wanted to confirm that will match the attachment as shown here?
Spoke with Fabio and resolved this issue. We will be moving forward with the solid green button due to testing results done earlier in the year.
Ignore my comment above. The conversation went further and we did decide moving forward with the outline was the correct treatment since the solid download button is right below in page. OUTLINE STAYS in the global nav! Final decision :)
Created attachment 8924489 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/5240
New sub nav is up on demo3: https://www-demo3.allizom.org/en-US/firefox/ Peiying, I believe the only new string here is "Extensions". All the others ("Desktop", "Mobile", "Blog") are already in main.lang . We would like to translate "Extensions", since it is the new correct term to use moving forward. I realize that we're not long until launch now however, so I've made non-English locales fall back to "Add-ons" for the time being. Hope this is OK? The same links are also now reflected in the global nav slide out menu (which is shown for en locales only)  https://github.com/mozilla-l10n/www.mozilla.org/blob/master/en-US/main.lang
Eric, also please note: I've not updated the blue highlight style shown in the mockup here, and left it using the current orange highlight instead. Doing the underline treatment would require some refactoring for both the sub-nav and global-nav styles, which could be a bit clumbersome to hide behind a switch. Also, the choice of blue may not be ideal here, since this would create insufficient contrast on black when applied in the slide out menu. For now, I think we should stick with the orange and revisit post launch when we can think about the wider impact of changes.
Thanks for the headsup. We have this word appeared in recently released new pages (mobile, hub/home-quantum), only some have completed the string/pages as communities are busy with many competing requests. I will enable it and transfer the localized strings to the main.lang file. The fall-back plan sounds good.
(In reply to Alex Gibson [:agibson] from comment #10) > Eric, also please note: > > I've not updated the blue highlight style shown in the mockup here, and left > it using the current orange highlight instead. Doing the underline treatment > would require some refactoring for both the sub-nav and global-nav styles, > which could be a bit clumbersome to hide behind a switch. Yes, perfect. > > Also, the choice of blue may not be ideal here, since this would create > insufficient contrast on black when applied in the slide out menu. For now, > I think we should stick with the orange and revisit post launch when we can > think about the wider impact of changes. +1
Hi Alex - Per product the Firefox glyph in the nav needs to get updated to the attached black gyph asap.
(In reply to christa seabolt from comment #14) > Hi Alex - Per product the Firefox glyph in the nav needs to get updated to > the attached black gyph asap. Sorry, we're code frozen this is too late. Please add it to the post-launch list.
Noted in the spreadsheet - https://docs.google.com/spreadsheets/d/1EARaDp-OwYo6RWWGibx4yc0XppGugGdqnXBVimpYUgM/edit#gid=2052741310
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/1c1a019a2b3d7fcbbbe76b74604ad2eedb7f9214 [fix bug 1409779] Update Firefox sub navigation for Quantum