Consider to remove the mousewheel.with* prefs from config files

RESOLVED FIXED in Thunderbird 68.0

Status

enhancement
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 68.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
When I checked if bug 143038 needs a port to TB/Claendar I found that we have only the prefs mousewheel.withcontrolkey.action in all-thunderbird.js and mousewheel.withnokey.action and mousewheel.withshiftkey.action in lightning.js. But this prefs have no other reference in any file. Are this prefs still for something?

The prefs in m-c are always mousewheel.with_* like mousewheel.with_shift.action or mousewheel.with_control.action.

Maybe we need to convert to the m-c names or delete our prefs.
Assignee

Comment 1

2 years ago
Philipp, as it affects calendar too, what do you think?
Flags: needinfo?(philipp)

Is this still a thing? I'd prefer delete if we don't need these.

Flags: needinfo?(philipp)
Assignee

Comment 3

a month ago

Okay, then remove them.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9058130 - Flags: review?(philipp)
Comment on attachment 9058130 [details] [diff] [review]
1410003-remove-mousewheel-prefs.patch

Review of attachment 9058130 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think I remember what this used to do. To verify we don't need to adapt to the new prefs please check this with a mouse that has a traditional up/down scroll wheel:

* Verify using the scroll wheel moves the hours up/down in day and week view
* Rotate the view
* Verify using the scroll wheel moves the hours left/right in the day and week view
* Verify the scroll wheel switches months/weeks in month and multiweek view.


r+ anyway because these prefs can go, but we may need a new patch if the above doesn't work.
Attachment #9058130 - Flags: review?(philipp) → review+
Assignee

Comment 5

a month ago

(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #4)

Comment on attachment 9058130 [details] [diff] [review]
1410003-remove-mousewheel-prefs.patch

Review of attachment 9058130 [details] [diff] [review]:

Actually I think I remember what this used to do. To verify we don't need to
adapt to the new prefs please check this with a mouse that has a traditional
up/down scroll wheel:

  • Verify using the scroll wheel moves the hours up/down in day and week view
  • Rotate the view

Works

  • Verify using the scroll wheel moves the hours left/right in the day and
    week view

Doesn't work. Mousewheel left/right clicking moves the hours.

  • Verify the scroll wheel switches months/weeks in month and multiweek view.

Works.

Keywords: checkin-needed

Comment 6

a month ago

So why not change the spelling to what FF has?

https://searchfox.org/comm-central/search?q=mousewheel.&case=false&regexp=false&path=
FF has:

pref("mousewheel.with_control.action",3);
pref("mousewheel.with_shift.action", 4);
Keywords: checkin-needed

Updated

a month ago
Attachment #9058130 - Flags: feedback-
Assignee

Comment 7

a month ago
Comment on attachment 9058130 [details] [diff] [review]
1410003-remove-mousewheel-prefs.patch

What the settings means: https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#2868

+++ b/calendar/lightning/content/lightning.js
-// Make sure mouse wheel shift and no key actions to scroll lines.
-pref("mousewheel.withnokey.action", 0);
-pref("mousewheel.withshiftkey.action", 0);

I see no difference in Calendar and TB when I set mousewheel.default.action or mousewheel.with_shift.action to "0".

+++ b/mail/app/profile/all-thunderbird.js
-pref("mousewheel.withcontrolkey.action", 3);

The default of mousewheel.with_control.action is already 3. So this pref can be removed.

So, what next?

Comment 8

a month ago
Comment on attachment 9058130 [details] [diff] [review]
1410003-remove-mousewheel-prefs.patch

OK, thanks for checking. I was wrong, sorry. Let's take the patch. For the record, yes, the prefs are already set:
mozilla/modules/libpref/init/all.js
2884 pref("mousewheel.with_shift.action", 4);

mozilla/modules/libpref/init/all.js
2882 pref("mousewheel.with_control.action", 3);
Attachment #9058130 - Flags: feedback-

Comment 9

a month ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4f2702e359aa
Remove no longer existing or misspelled mousewheel prefs. r=philipp

Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED

Updated

a month ago
Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.