Closed Bug 1410033 Opened 3 years ago Closed 3 years ago

Port Bug 1409635 (part 2) to mailnews: Fix up nsIPrefLocalizedString - compile error in nsAbDirProperty.cpp(586) and nsMsgSearchAdapter.cpp(245)

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file, 1 obsolete file)

mailnews/addrbook/src/nsAbDirProperty.cpp(586): error C2664: 'nsresult nsISupportsString::SetData(const nsAString &)': cannot convert argument 1 from 'nsTString<char16_t>::raw_type<T,int>::type' to 'const nsAString &'

mailnews/base/search/src/nsMsgSearchAdapter.cpp(245): error C2664: 'nsresult nsISupportsString::GetData(nsAString &)': cannot convert argument 1 from 'nsTGetterCopies<char16_t>' to 'nsAString &'

Looks like we need to remove .get() and the getter_Copies().

Patch coming.
This might be a bit of a "whack a mole" exercise. There are only two errors shown on the tree, but there might be more. The patch fixes those first two. Let's see how the local compile goes.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Summary: Port Bug 1409635 (part 2) to mailnews: Fix up nsIPrefLocalizedString → Port Bug 1409635 (part 2) to mailnews: Fix up nsIPrefLocalizedString - compile error in nsAbDirProperty.cpp(586) and nsMsgSearchAdapter.cpp(245)
This may do it, or there might be more. I'll land it once the local compile is through.
Attachment #8920098 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bd338ab46d1d
Port Bug 1409635 (part 2) to mailnews [Fix up nsIPrefLocalizedString]. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.