Hi, I’m a recent CS graduate and would like to start contributing. Would I be able to take care of this? Thanks! Nicole Byer
Hi Mike, I got a working build of Firefox and changed the line of code (I'll attach the file). What is the next step? Do I need to test this? Thanks for your help! Nicole
Lines 20-21 changed to use Number.MAX_SAFE_INTEGER
Hi Nicole, great that you've been able to get a build running! Next step is to submit a patch for review. You can read all about that here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch This is step 4 in the Contributing tutorial at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction.
Ok, great! Are you the reviewer? (I also see ttaubert when I run hg annotate). Thanks!
Yeah, I'm the module owner, so I can review your patch.
Changed lines 20-21 to use Number.MAX_SAFE_INTEGER
Comment on attachment 8921478 [details] [diff] [review] SessionCookies.jsm Nicole, the file you attached is not a patch, but the whole SessionCookies.jsm file, which is something we can't really review. We always review sets of changes (i.e. a patch), which is quite a bit smaller and doesn't require you to point out what you've changed and where you changed something. Instead you can focus on explaining why you made the change in a commit message. I really recommend you to give https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch a thorough read-through to see how you can generate a patch.
Hi, Sorry about that; I hope this is more along the right lines!
Comment on attachment 8921544 [details] [diff] [review] Proposed patch Review of attachment 8921544 [details] [diff] [review]: ----------------------------------------------------------------- Perfect! Thanks for this :)
Attachment #8921544 - Flags: review?(mdeboer) → review+
Assignee: nobody → nicole_byer
Status: NEW → ASSIGNED
Great, thanks for your help!
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/44a2659e778a Changed use of 2^62 to Number.MAX_SAFE_INTEGER (represents 2^53 - 1) to avoid faulty behavior. r=mikedeboer
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.