It is difficult to determine which crash pings are from ShutDownKill

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chutten, Assigned: chutten)

Tracking

(Blocks 1 bug)

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(2 attachments)

crash pings contain a lot of information, some of which is surfaced in crash_summary. Whether the ping describes a shutdownkill[1] is not something that's easy to tell.

:gsvelto noted that the stackTraces.crash_info.type field would be EXCEPTION_BREAKPOINT for shutdownkill. This could be added to crash_summary.

However, it's _just_ generic enough that I don't feel comfortable doing so. 

In contrast, "main" pings (serving the content_shutdown_crash counts to crash_aggregates and error_aggregates) have a direct line to shutdownkill via SUBPROCESS_KILL_HARD/ShutDownKill. Crash Stats has a similar direct annotation with ipc_channel_error=ShutDownKill.

Crash pings deserves its own direct line to determine if it is describing this common (and usually ignorable) kind of crash.

(Perhaps we just need to whitelist[2][3] ipc_channel_error so it is included in crash pings' metadata? Then crash_summary gets it for "free")

[1]: http://searchfox.org/mozilla-central/source/dom/ipc/ContentParent.cpp#3028
[2]: http://searchfox.org/mozilla-central/source/toolkit/components/crashes/CrashManager.jsm#227
[3]: http://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/ping.cpp#124
Whitelisting 'ipc_channel_error' should be trivial but it requires a data review.
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Comment on attachment 8920671 [details]
bug 1410143 - Whitelist ipc_channel_error for crash pings data-r?rweiss

data-r?rweiss
Attachment #8920671 - Flags: feedback?(rweiss)
Comment on attachment 8920671 [details]
bug 1410143 - Whitelist ipc_channel_error for crash pings data-r?rweiss

https://reviewboard.mozilla.org/r/191672/#review196936

LGTM with two nits:
* Add documentation for the new field in toolkit/components/telemetry/docs/data/crash-ping.rst
* Add a check in http://searchfox.org/mozilla-central/rev/bc6dddb88b1f34b54e22efc205846975fb4c04cb/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js#464 to verify that the new field is indeed being stored into the ping
Attachment #8920671 - Flags: review?(gsvelto) → review+
:chutten Can you fill out this form (https://github.com/mozilla/data-review/blob/master/request.md) and include in this bug, either as a gist link, a text file, or as a comment?
Flags: needinfo?(chutten)
Flags: needinfo?(chutten)
Attachment #8923792 - Flags: review?(rweiss)
Priority: -- → P1
Comment on attachment 8923792 [details]
Data Collection Review Form

1. These will be added to crash pings.  I assume this means they will follow standard Telemetry documentation standards.
2. Yes, people can opt out via data preferences and they are not required to submit crash reports.
3. Yes, chutten will be.
4. Category 1.
5. Default off, but data can be submitted via all channels and countries and locales.
6. No new identifiers.
7. Yes, this is covered.
8. A check in is not needed.
Attachment #8923792 - Flags: review?(rweiss) → review+
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4e2e8992d06
Whitelist ipc_channel_error for crash pings data-r?rweiss r=gsvelto
https://hg.mozilla.org/mozilla-central/rev/f4e2e8992d06
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.