Closed
Bug 1410155
Opened 7 years ago
Closed 7 years ago
Store hash of uploaded .sym symbols
Categories
(Socorro :: Symbols, task)
Socorro
Symbols
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
References
Details
Attachments
(1 file)
When we upload .sym files, they're plaintext. So we gzip it. Then once gzipped we can compare its gzipped size with what size the file is in S3.
One way to avoid the gzip altogether is store the hash of the file as S3 metadata. Then, when assessing a new .sym file, we can compare its hash in S3 with the hash locally. If the hashes match, there's no need to gzip the file at all to compare with the local file. Potentially a lot of I/O savings when the upload is repeated.
Might be a good idea to store the hash AND the original file size.
Assignee | ||
Comment 1•7 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1409842 changes how lookups are done quite significantly. Best wait for that to land first.
Assignee: nobody → peterbe
Depends on: 1409842
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla-services/tecken
https://github.com/mozilla-services/tecken/commit/c0223a9dbb609d3b3c12d028f00a434de9b32bb6
fixes bug 1410155 - Store hash of uploaded .sym symbols (#494)
* fixes bug 1410155 - Store hash of uploaded .sym symbols
* leftover
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•