Closed Bug 1410203 Opened 6 years ago Closed 6 years ago

Only skip building mozharness package when building with comm-central as the top-level directory.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(2 files)

Bug 1410203: Expose whether a build has comm-central as a topdir;
59 bytes, text/x-review-board-request
gps
: review+
Fallen
: review+
Details
Bug 1410203: Don't build mozharness package when in comm-topdir build, rather than any thunderbird build;
59 bytes, text/x-review-board-request
gps
: review+
Details 
In Bug 1221356, mozharness.zip stopped being packaged for thunderbird builds, because it didn't support being built when comm-central was the top-level directory. Now that there is the start of support for building thunderbird with mozilla-central as the top-level directory, this should be changed to only skip building when c-c is the top-level directory.
Comment on attachment 8920319 [details]
Bug 1410203: Don't build mozharness package when in comm-topdir build, rather than any thunderbird build;

https://reviewboard.mozilla.org/r/191324/#review196480

This needs to land after the comm-central patch lands, to avoid breaking builds with comm-central as top-level directory.
Comment on attachment 8920318 [details]
Bug 1410203: Expose whether a build has comm-central as a topdir;

https://reviewboard.mozilla.org/r/191330/#review196508
Attachment #8920318 - Flags: review?(gps) → review+
Comment on attachment 8920319 [details]
Bug 1410203: Don't build mozharness package when in comm-topdir build, rather than any thunderbird build;

https://reviewboard.mozilla.org/r/191326/#review196510
Attachment #8920319 - Flags: review?(gps) → review+
Comment on attachment 8920318 [details]
Bug 1410203: Expose whether a build has comm-central as a topdir;

https://reviewboard.mozilla.org/r/191330/#review196708
Attachment #8920318 - Flags: review?(philipp) → review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/981003e749b7
Expose whether a build has comm-central as a topdir; r=gps,Fallen
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/68c67014c8e1
Don't build mozharness package when in comm-topdir build, rather than any thunderbird build; r=gps
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.