141022 - DOM Inspector crash if "CSS Style rules" is selected on element matching no rules [@nsInspectorCSSUtils::IsRuleNodeRoot]

Status: VERIFIED FIXED

(Other Applications :: DOM Inspector, defect, P1)

Description

[Itamar]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0+) Gecko/20020428
BuildID:    2002042808

Dom Inspector crash mozilla if CSS Style Rules option is selected upon a local
loaded xml file.

Reproducible: Always
Steps to Reproduce:
1.save the following lines to an xml file:

<?xml version="1.0" encoding="ISO-8859-1"?>
<channel>
</channel>

2. Open Dom inspector
3. Load the file you just saved to the DOM Inspector.
4. select the channel node.
5. from the "Object - Dom Node" popup menu select "CSS Style Rules"

Actual Results:  Mozilla crash

Expected Results:  :-)

TBID: TB5746619Q

Comment 1

[timeless]

this is a well known crash, unfortunately i can't find any bug report for it.

Comment 2

[Andrew Schultz]

Attachment: stacktrace

Comment 3

[Andrew Schultz]

crash also occurs with linux build 20020428.
this started somewhere between builds 2002021810 and 2002022015.

Comment 4

[Andrew Schultz]

before bug 79091, there was a null check on ruleNode before it was checked for
IsRoot().  From attachment 69706 [details] [diff] [review]:

-    ruleNode = ruleNode->GetParent();
-    
-    // don't be adding that there root node
-    if (!ruleNode || ruleNode->IsRoot())
-      break;
-  }
+    mCSSUtils->GetRuleNodeParent(ruleNode, &ruleNode);
+    mCSSUtils->IsRuleNodeRoot(ruleNode, &isRoot);
+  } while (!isRoot);

(there is no null check in IsRuleNodeRoot)

Comment 5

[timeless]

=>dbaron

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This patch is better than just a null-check:  the problem is that we need to do
the |IsRoot| check before entering the loop, that is, a while loop rather than
a do-while loop.  I converted it to a for loop while I was there, since I like
for loops.

Comment 7

[Chris Waterson]

Comment on attachment 86764 [details] [diff] [review]
patch

sr=waterson

Comment 8

[Andrew Schultz]

*** Bug 150443 has been marked as a duplicate of this bug. ***

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 86764 [details] [diff] [review]
patch

r=hewitt

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2002-06-11 20:30 PDT.

Comment 11

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_0_BRANCH, 2002-06-20 19:53 PDT.

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 154631 has been marked as a duplicate of this bug. ***

Comment 14

[timeless]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020830
vrfy fixed
steps: loaded url, selected root node "channel", selected CSS Style Rules.