Closed
Bug 1410232
Opened 7 years ago
Closed 7 years ago
fix SchedulerGroupSet::Put when transitioning to multiple groups
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
992 bytes,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
We were moving state from single -> multi, but we weren't doing anything with the group that was passed in for such cases.
Assignee | ||
Comment 1•7 years ago
|
||
This feels like I'm missing something, but I can't see why the existing behavior isn't a bug...
Attachment #8920361 -
Flags: review?(wmccloskey)
Comment on attachment 8920361 [details] [diff] [review] fix SchedulerGroupSet::Put when transitioning to multiple groups Review of attachment 8920361 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/threads/nsILabelableRunnable.cpp @@ +51,2 @@ > mSingle = nullptr; > return; Ugh, yeah, you're right. I think I overlooked the return statement when I read this.
Attachment #8920361 -
Flags: review?(wmccloskey) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/baa55120263b fix SchedulerGroupSet::Put when transitioning to multiple groups; r=billm
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/baa55120263b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•