Closed Bug 1410235 Opened 4 years ago Closed 4 years ago

Only open a custom tab for out-of-scope URLs if Gecko is going to show it

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

defect

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: snorp, Assigned: droeh)

References

Details

Attachments

(1 file)

Most likely the easiest thing to do here is only allow http[s] for the custom tab and fire a VIEW intent for everything else.
This launches a custom tab for http(s) URIs, and otherwise fires an ACTION_VIEW intent.
Attachment #8922397 - Flags: review?(snorp)
Comment on attachment 8922397 [details] [diff] [review]
Only launch a custom tab for http(s) URIs

Review of attachment 8922397 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this is an improvement, but I wonder if we should try to do what Fennec does here and use some of the stuff in IntentHelpers.java. This would make intent:// links work, for instance.
Attachment #8922397 - Flags: review?(snorp) → review+
Dylan you need to land this if it's ready.
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a09e84747d93
Only launch a custom tab from a PWA for http(s) URIs, otherwise just fire an ACTION_VIEW intent. r=snorp
https://hg.mozilla.org/mozilla-central/rev/a09e84747d93
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.