1410239 - Remove skip-if and random-if WR reftest annotations

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

We have some reftests that I marked random-if or skip-if during the switch to layers free. More things have been fixed since then and these reftests are mostly good now. At least they're not behaving randomly.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Here I just removed the annotations to see what happens:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50a014d8fef00cb518b7486e01e8683922449be8

Looks like one is permafailing and one is still failing to load, probably because we didn't implement the mozPrintCallback thing for canvases.

Here's my attempted fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0d4aa78d4851a78a667c60b26e690734035b5c

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Cleared out some more random-if's that I missed the first time around: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f5a22d5100a09c5b37211c067b72107acb65313

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410239 - Remove some random-if(webrender) annotations.

Review commit: https://reviewboard.mozilla.org/r/191410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191410/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410239 - Ensure the mozPrintCallback gets invoked when painting canvases.

Review commit: https://reviewboard.mozilla.org/r/191412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191412/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8920440 [details]
Bug 1410239 - Remove some random-if(webrender) annotations.

https://reviewboard.mozilla.org/r/191410/#review196606

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8920441 [details]
Bug 1410239 - Ensure the mozPrintCallback gets invoked when painting canvases.

https://reviewboard.mozilla.org/r/191412/#review196608

Comment 7

[Kartikaya Gupta (email:[e-mail])]

From the try push I did at https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb09d10f74f3b4523d0abd37e0ba32bdc8d46aeb it looks like anim-pattern-attr-presence-01.svg is actually basically passing, but has a variable fuzziness. Highest fuzzy needed so far is (1,350). I'll change that one from fails-if to fuzzy-if.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Just to be extra safe I retriggered the reftests a bunch on this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=779d7b8ff894807106299dd036d1d106730d3ea4

Looks like ogg-video/444-1-ref.html is still sometimes rendering the video at the wrong scale. no idea why. But I'll leave that one as random-if.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8920440 [details]
Bug 1410239 - Remove some random-if(webrender) annotations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191410/diff/1-2/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8920441 [details]
Bug 1410239 - Ensure the mozPrintCallback gets invoked when painting canvases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191412/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feca3ac01227
Remove some random-if(webrender) annotations. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/573274df0d0e
Ensure the mozPrintCallback gets invoked when painting canvases. r=jrmuizel

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/feca3ac01227
https://hg.mozilla.org/mozilla-central/rev/573274df0d0e