1410279 - "e10s (pid)" no longer show on tab's tooltip in Nightly

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[YF (Yang)]

i.e. Bug 1333277 - [multi-e10s] add pid of a tab to tooltip


Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=84b2d5c67f73b48b760ef3f12aed9e8796441635&tochange=1485df2619bce4f7f424d1f1ff6b883ed7f23b26

1485df2619bc	Dragana Damjanovic — Bug 1408019 - Code clean up for sSupportedRelValues. r=bz

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I arrived here after going through mozregression and finding the same thing as Yang above. The hover PIDs are very useful for quickly identifying to which process to attach a debugger.

Comment 2

[Ekanan Ketunuti]

I had retested with that build but unfortunately bug 1408019 is not a regressor.

https://tools.taskcluster.net/index/artifacts/gecko.v2.mozilla-inbound.revision.1485df2619bce4f7f424d1f1ff6b883ed7f23b26.firefox/win32-pgo

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

yeah, we need the process ids back. That information is super useful for debugging (also in opt builds when doing performance work).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b721be9535ab
Fix bad merge of bug 1407351, restoring the process id indicator on tabs (nightly only). r=me

Comment 6

[:Felipe Gomes (needinfo for replies!)]

(In reply to Olli Pettay [:smaug] (work week Oct 16-20) from comment #4)
> yeah, we need the process ids back. That information is super useful for
> debugging (also in opt builds when doing performance work).

Sorry, it was not intentional that it got removed, just a bad merge.

Note: there's a small change in that the tab won't say "e10s" anymore. It will just be
"tab title (pid: NNNN)" for remote tabs.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b721be9535ab