Closed
Bug 1410281
Opened 7 years ago
Closed 7 years ago
use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
We missed one instance of style attribute parsing in bug 1406277 that needs to change to using GetBaseURIForStyleAttr().
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6cc8bceca62c751a39862d37f86ebba4a80b857
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8920432 [details] Bug 1410281 - Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer. https://reviewboard.mozilla.org/r/191406/#review196588 ::: dom/base/nsTreeSanitizer.cpp:1163 (Diff revision 1) > int32_t attrNs = attrName->NamespaceID(); > RefPtr<nsAtom> attrLocal = attrName->LocalName(); > > if (kNameSpaceID_None == attrNs) { > if (aAllowStyle && nsGkAtoms::style == attrLocal) { > - nsCOMPtr<nsIURI> baseURI = aElement->GetBaseURI(); > + nsCOMPtr<nsIURI> baseURI = aElement->GetBaseURIForStyleAttr(); `nsIURI*` is enough. Actually you can merge this into `ParseStyleAttribute` call directly as that's the only place uses it.
Attachment #8920432 -
Flags: review?(xidorn+moz) → review+
Comment hidden (mozreview-request) |
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4b50a948629 Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer. r=xidorn
Updated•7 years ago
|
Priority: -- → P3
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b4b50a948629
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•