1410281 - use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

We missed one instance of style attribute parsing in bug 1406277 that needs to change to using GetBaseURIForStyleAttr().

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6cc8bceca62c751a39862d37f86ebba4a80b857

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1410281 - Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer.

Review commit: https://reviewboard.mozilla.org/r/191406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191406/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8920432 [details]
Bug 1410281 - Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer.

https://reviewboard.mozilla.org/r/191406/#review196588

::: dom/base/nsTreeSanitizer.cpp:1163
(Diff revision 1)
>      int32_t attrNs = attrName->NamespaceID();
>      RefPtr<nsAtom> attrLocal = attrName->LocalName();
>  
>      if (kNameSpaceID_None == attrNs) {
>        if (aAllowStyle && nsGkAtoms::style == attrLocal) {
> -        nsCOMPtr<nsIURI> baseURI = aElement->GetBaseURI();
> +        nsCOMPtr<nsIURI> baseURI = aElement->GetBaseURIForStyleAttr();

`nsIURI*` is enough. Actually you can merge this into `ParseStyleAttribute` call directly as that's the only place uses it.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8920432 [details]
Bug 1410281 - Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191406/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4b50a948629
Use GetBaseURIForStyleAttr for style attribute base URI in nsTreeSanitizer. r=xidorn

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b4b50a948629