Closed Bug 1410288 Opened 4 years ago Closed 4 years ago

Change nsIPrintProgressParams' attributes from wstring to AString

Categories

(Toolkit :: Printing, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

It makes the C++ code nicer.
This is similar to bug 1407103, but a smaller change.
Attachment #8920439 - Flags: review?(bobowencode)
Comment on attachment 8920439 [details] [diff] [review]
Change nsIPrintProgressParams' attributes from wstring to AString

Review of attachment 8920439 [details] [diff] [review]:
-----------------------------------------------------------------

Only comment is that we appear to have identical implementations for nsPrintProgressParams for unixshared and win.
Attachment #8920439 - Flags: review?(bobowencode) → review+
> Only comment is that we appear to have identical implementations for
> nsPrintProgressParams for unixshared and win.

Yes. That was pre-existing, and I wasn't sure where to put a shared implementation, so I left that unfixed for now :/
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e391c3586f9a6b2e5496915c0c1357eb93e30ad
Bug 1410288 - Change nsIPrintProgressParams' attributes from wstring to AString. r=bobowen.
(In reply to Nicholas Nethercote [:njn] from comment #3)
> > Only comment is that we appear to have identical implementations for
> > nsPrintProgressParams for unixshared and win.
> 
> Yes. That was pre-existing, and I wasn't sure where to put a shared
> implementation, so I left that unfixed for now :/

I almost didn't mention it for exactly the same reasons. :-)
https://hg.mozilla.org/mozilla-central/rev/7e391c3586f9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1427553
You need to log in before you can comment on or make changes to this bug.