Change nsIPrintProgressParams' attributes from wstring to AString

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Printing
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago
It makes the C++ code nicer.
(Assignee)

Comment 1

a month ago
Created attachment 8920439 [details] [diff] [review]
Change nsIPrintProgressParams' attributes from wstring to AString

This is similar to bug 1407103, but a smaller change.
Attachment #8920439 - Flags: review?(bobowencode)

Comment 2

a month ago
Comment on attachment 8920439 [details] [diff] [review]
Change nsIPrintProgressParams' attributes from wstring to AString

Review of attachment 8920439 [details] [diff] [review]:
-----------------------------------------------------------------

Only comment is that we appear to have identical implementations for nsPrintProgressParams for unixshared and win.
Attachment #8920439 - Flags: review?(bobowencode) → review+
(Assignee)

Comment 3

a month ago
> Only comment is that we appear to have identical implementations for
> nsPrintProgressParams for unixshared and win.

Yes. That was pre-existing, and I wasn't sure where to put a shared implementation, so I left that unfixed for now :/
(Assignee)

Comment 4

a month ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e391c3586f9a6b2e5496915c0c1357eb93e30ad
Bug 1410288 - Change nsIPrintProgressParams' attributes from wstring to AString. r=bobowen.

Comment 5

a month ago
(In reply to Nicholas Nethercote [:njn] from comment #3)
> > Only comment is that we appear to have identical implementations for
> > nsPrintProgressParams for unixshared and win.
> 
> Yes. That was pre-existing, and I wasn't sure where to put a shared
> implementation, so I left that unfixed for now :/

I almost didn't mention it for exactly the same reasons. :-)
https://hg.mozilla.org/mozilla-central/rev/7e391c3586f9
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.