1410288 - Change nsIPrintProgressParams' attributes from wstring to AString

Status: RESOLVED FIXED

(Toolkit :: Printing, enhancement)

Description

[Nicholas Nethercote [inactive]]

It makes the C++ code nicer.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Change nsIPrintProgressParams' attributes from wstring to AString

This is similar to bug 1407103, but a smaller change.

Comment 2

[Bob Owen (:bobowen) (PTO until 17th Apr)]

Comment on attachment 8920439 [details] [diff] [review]
Change nsIPrintProgressParams' attributes from wstring to AString

Review of attachment 8920439 [details] [diff] [review]:
-----------------------------------------------------------------

Only comment is that we appear to have identical implementations for nsPrintProgressParams for unixshared and win.

Comment 3

[Nicholas Nethercote [inactive]]

> Only comment is that we appear to have identical implementations for
> nsPrintProgressParams for unixshared and win.

Yes. That was pre-existing, and I wasn't sure where to put a shared implementation, so I left that unfixed for now :/

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e391c3586f9a6b2e5496915c0c1357eb93e30ad
Bug 1410288 - Change nsIPrintProgressParams' attributes from wstring to AString. r=bobowen.

Comment 5

[Bob Owen (:bobowen) (PTO until 17th Apr)]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> > Only comment is that we appear to have identical implementations for
> > nsPrintProgressParams for unixshared and win.
> 
> Yes. That was pre-existing, and I wasn't sure where to put a shared
> implementation, so I left that unfixed for now :/

I almost didn't mention it for exactly the same reasons. :-)

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7e391c3586f9