1410361 - [dt-onboarding] UX: should not open more than one about:devtools tab

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

During one session where I had disabled devtools on my profile (and forgot about it), I triggered the devtools onboarding page when pressing a DT shortcut.

Seeing that it was not doing what I expected (opening a tab vs opening devtools), I instantly pressed the shortcut again ("why is this not working!"). I ended up with 5 tabs of about:devtools opened.

I think we should only ever open one tab of about:devtools. 

Alternatively, maybe we could also think about enabling DevTools if the user triggers a DevTools entry point while being on the DevTools onboarding page?

Comment 1

[Julian Descottes [:jdescottes]]

Victoria, does the following change seem fine to you: 

On a given window, if an about:devtools tab is already opened and the user triggers a devtools shortcut again, focus the existing tab rather than opening multiple about:devtools tabs.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1410361 - reuse existing tab of about:devtools;

Review commit: https://reviewboard.mozilla.org/r/193362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193362/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8922313 [details]
Bug 1410361 - reuse existing tab of about:devtools;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193362/diff/1-2/

Comment 4

[Victoria Wang [:victoria]]

Yes, it would be great to focus the existing tab rather than multiple about:devtools tabs.

(As for the idea of enabling DevTools if user triggers entry point while on the onboarding page - I think I'd rather keep it a very deliberate "Activate" action for now since that's more similar to the eventual "Install" action.) 

Thanks!

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8922313 [details]
Bug 1410361 - reuse existing tab of about:devtools;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193362/diff/2-3/

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8922313 [details]
Bug 1410361 - reuse existing tab of about:devtools;

https://reviewboard.mozilla.org/r/193362/#review199986

Looks good to me !

Comment 7

[Julian Descottes [:jdescottes]]

thanks for the review! try is green at https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f3d0d5b7f564cb2d688e7b9ffd0b1e40247cf1d, landing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd1e9860b7d6
reuse existing tab of about:devtools;r=nchevobbe

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cd1e9860b7d6