1410411 - Correlation: changing the channel doesn't update the url

Status: NEW

(Socorro :: Webapp, task)

Description

[Sylvestre Ledru [:Sylvestre]]

For example, on:
https://crash-stats.mozilla.com/signature/?product=Firefox&signature=libsystem_kernel.dylib%400x1bfce&date=%3E%3D2017-07-20T13%3A21%3A04.000Z&date=%3C2017-10-20T13%3A21%3A04.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#correlations
if I change the channel to beta, the url isn't updated.

This would be great to update the url to be able to share it

Comment 1

[Marco Castelluccio [:marco]]

You can do it manually by adding e.g. "release_channel=beta" to the URL. I agree adding it automatically would be a nice feature.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

So, what's going on is that there are two different levels of filters. There are filters that apply to all the tabs for that signature report which you can access using the "Filters" toggle. Then there's the product and channel dropdowns that are just on the correlations tab.

When you add "release_channel=beta", that changes the filters that apply to all the tabs and sets the channel in the correlations tab, too.

It feels confusing to me to have dropdowns that apply just to the correlations tab to apply to all the tabs plus it'd be had to do the javascript have changes in the correlations dropdown affect the filters.

I can think of one of a couple of options:

1. Disconnect the correlations tabs dropdowns from the filters completely such that it's a separate set of url parameters. Maybe "correlations_product" and "correlations_release_channel".

2. Remove the correlations tabs dropdowns, fix the code to use the filter values, and add instructions telling users to adjust the filters.

I think the first option is probably the most ergonomic one for users and the second one is annoying since the filters are hard to adjust especially if you're switching between two values.

What do you think? Do you have other ideas? Which would you prefer?

Comment 3

[Marco Castelluccio [:marco]]

I agree, option 1 seems better, maybe making those "correlation_" parameters be the same as the filters by default (that is, on first load).

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I will rely on Marco for the best option :)