1410454 - mach bootstrap for Firefox for Android broken on Ubuntu 16.04

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Eugen Sawin [:esawin]]

Please choose the version of Firefox you want to build:
1. Firefox for Desktop Artifact Mode
2. Firefox for Desktop
3. Firefox for Android Artifact Mode
4. Firefox for Android
Your choice: 4
Executing as root: sudo apt-get install autoconf2.13 build-essential ccache python-dev python-pip python-setuptools unzip uuid zip
Reading package lists... Done
Building dependency tree       
Reading state information... Done
build-essential is already the newest version (12.1ubuntu2).
ccache is already the newest version (3.2.4-1).
python-dev is already the newest version (2.7.11-1).
python-setuptools is already the newest version (20.7.0-1).
unzip is already the newest version (6.0-20ubuntu1).
zip is already the newest version (3.0-11).
autoconf2.13 is already the newest version (2.13-67).
uuid is already the newest version (1.6.2-1.5build2).
python-pip is already the newest version (8.1.1-2ubuntu0.4).
The following packages were automatically installed and are no longer required:
  linux-headers-4.4.0-92 linux-headers-4.4.0-92-generic linux-image-4.4.0-92-generic linux-image-extra-4.4.0-92-generic
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 9 not upgraded.
Executing as root: sudo dpkg --add-architecture i386
Executing as root: sudo apt-get update
Ign:1 http://dl.google.com/linux/chrome/deb stable InRelease
Get:2 http://apt.llvm.org/xenial llvm-toolchain-xenial-3.9 InRelease [4.207 B]                                                                        
Hit:3 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu xenial InRelease                                                                                   
Hit:4 http://de.archive.ubuntu.com/ubuntu xenial InRelease
     Hit:5 http://dl.google.com/linux/chrome/deb stable Release                                                                                      [15/980816]
Hit:6 http://de.archive.ubuntu.com/ubuntu xenial-updates InRelease                                    
Ign:2 http://apt.llvm.org/xenial llvm-toolchain-xenial-3.9 InRelease                                  
Hit:7 http://de.archive.ubuntu.com/ubuntu xenial-backports InRelease     
Hit:8 http://security.ubuntu.com/ubuntu xenial-security InRelease        
Fetched 4.207 B in 0s (8.838 B/s)                 
Reading package lists... Done
W: GPG error: http://apt.llvm.org/xenial llvm-toolchain-xenial-3.9 InRelease: The following signatures couldn't be verified because the public key is not a
vailable: NO_PUBKEY 15CF4D18AF4F7421
W: The repository 'http://apt.llvm.org/xenial llvm-toolchain-xenial-3.9 InRelease' is not signed.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
Executing as root: sudo apt-get install default-jdk wget libncurses5:i386 libstdc++6:i386
Reading package lists... Done
Building dependency tree       
Reading state information... Done
default-jdk is already the newest version (2:1.8-56ubuntu2).
libncurses5:i386 is already the newest version (6.0+20160213-1ubuntu1).
wget is already the newest version (1.17.1-1ubuntu1.2).
libstdc++6:i386 is already the newest version (5.4.0-6ubuntu1~16.04.5).
The following packages were automatically installed and are no longer required:
  linux-headers-4.4.0-92 linux-headers-4.4.0-92-generic linux-image-4.4.0-92-generic linux-image-extra-4.4.0-92-generic
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 9 not upgraded.
Error running mach:

    ['bootstrap']
     
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.
        
The details of the failure are as follows:

ImportError: No module named android

  File "/home/esawin/dev/g/python/mozboot/mozboot/mach_commands.py", line 32, in bootstrap
    bootstrapper.bootstrap()
  File "/home/esawin/dev/g/python/mozboot/mozboot/bootstrap.py", line 296, in bootstrap
    getattr(self.instance, 'install_%s_packages' % application)()
  File "/home/esawin/dev/g/python/mozboot/mozboot/debian.py", line 106, in install_mobile_android_packages
    self.ensure_mobile_android_packages()
  File "/home/esawin/dev/g/python/mozboot/mozboot/debian.py", line 131, in ensure_mobile_android_packages
    import android
  File "/home/esawin/dev/g/build/mach_bootstrap.py", line 353, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1410454 - Fix ImportError regression in mozboot,

This fixes a regression from bug 1408365. Ideally these imports would
be defined at the top of the file, then the py2 linter would have caught
them. Even more ideally, mozboot would have some tests that hit these
code paths.

Review commit: https://reviewboard.mozilla.org/r/191660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191660/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8920666 [details]
Bug 1410454 - Fix ImportError regression in mozboot,

https://reviewboard.mozilla.org/r/191660/#review196866

This makes sense and should fix the |mach bootstrap| errors.  ahal is testing the `curl | python` flow as we speak.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a550fea9a6cd
Fix ImportError regression in mozboot, r=nalexander

Comment 4

[Andrew Halberstadt [:ahal]]

The download one-liner wfm as well.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a550fea9a6cd