Closed Bug 1410467 Opened 7 years ago Closed 6 years ago

Audioipc is unconditionally enabled on Linux builds

Categories

(Core :: Audio/Video: cubeb, defect, P3)

Unspecified
Linux
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: philn, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

The MOZ_CUBEB_REMOTING #define added in CubebUtils.cpp prevents conditional disabling the audioipc support.

In gecko-media I think we would like to disable this feature for now. Chris, please confirm :) One way to fix the issue would be to move the #define in the config.h header and then we could easily undef it in gecko-media's build.
Component: Untriaged → Audio/Video: cubeb
OS: Unspecified → Linux
Product: Firefox → Core
Blocks: servo-media
The preferred way to do this is to add a configure option (--enable-audio-remoting). 

Matthew, is that something we could do/want to do? Apparently this is blocking the "standalone media stack" project.
Flags: needinfo?(kinetik)
We just removed the configure option when we enabled remoting in bug 1407487 because typically the non-default options end up being broken.  If you really need this, you could restore that option, but make it default to on and be prepared to deal with breakage if it happens.
Flags: needinfo?(kinetik)
Use configure system to enable cubeb remoting on linux by
default. Disabling is supported by adding
  ac_add_options --disable-cubeb-remoting
to mozconfig.

MozReview-Commit-ID: 5SfER036LDf
Attachment #8921680 - Flags: feedback?(philn)
Attachment #8921680 - Flags: feedback?(cpearce)
Comment on attachment 8921680 [details] [diff] [review]
Control cubeb remoting via --disable-cubeb-remoting.

Review of attachment 8921680 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/moz.configure
@@ +1151,5 @@
> +@depends(target)
> +def cubeb_remoting_default(target):
> +    # Turn off cubeb remoting for OS's we don't handle yet, but allow
> +    # --enable-cubeb-remoting to override.
> +    if target.raw_os.startswith('linux'):

This will match "linuxandroid", which we don't want.  I'm not sure when target.raw_os has that value instead of "android", but there are other locations in the build code expecting this.
Use configure system to enable cubeb remoting on linux by
default. Disabling is supported by adding
  ac_add_options --disable-cubeb-remoting
to mozconfig.

MozReview-Commit-ID: 5SfER036LDf
Attachment #8921680 - Attachment is obsolete: true
Attachment #8921680 - Flags: feedback?(philn)
Attachment #8921680 - Flags: feedback?(cpearce)
Attachment #8921752 - Flags: feedback?(cpearce)
(In reply to Matthew Gregan [:kinetik] from comment #5)
> This will match "linuxandroid", which we don't want.  I'm not sure when
> target.raw_os has that value instead of "android", but there are other
> locations in the build code expecting this.

Ugh. Linux/Android. Why so hard?

I've updated to exclude linuxandroid. Thanks!
Thanks, yes, we'd like to be able to run cubeb in gecko-media in the local process, at least to begin with.

You could avoid the configure option with just adding the #define in the moz.build files of the dirs that need it defined.
Comment on attachment 8921752 [details] [diff] [review]
Control cubeb remoting via --disable-cubeb-remoting.

Review of attachment 8921752 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but it's probably easier to just add defines you need in moz.build files; we're not using anything from the mozilla build system in gecko-media, so then we'd not see the defines. But whatever works best for you...
Attachment #8921752 - Flags: feedback?(cpearce)
Audiopic breaks the compile on musl-amd64 for firefox-60.0, is it intentional to enable it?
(In reply to tt_1 from comment #10)
> Audiopic breaks the compile on musl-amd64 for firefox-60.0, is it
> intentional to enable it?

Yes, it is intentionally enabled.  Please file a new bug with details of the build breakage.

Marking this bug as obsolete, since bug 1388605 is dead now.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: