Closed Bug 1410472 Opened 7 years ago Closed 7 years ago

clang-plugin should follow the LLVM coding style for real

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Bug 1410472 - clang-plugin follows the LLVM coding style for real
59 bytes, text/x-review-board-request
nika
: review+
Details 
Currently, we have some differences
Comment on attachment 8920638 [details]
Bug 1410472 - clang-plugin follows the LLVM coding style for real

https://reviewboard.mozilla.org/r/191624/#review196908

I presume this was done automatically with clang-format so I haven't gone over it with a fine-toothed comb :-).

Thanks!
Attachment #8920638 - Flags: review?(nika) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88c9b8587db6
clang-plugin follows the LLVM coding style for real r=mystor
https://hg.mozilla.org/mozilla-central/rev/88c9b8587db6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Indeed, just a plain clang format on the sources :)
Assignee: nobody → sledru
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: